New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.5 Fixed wrong translation domain in templates when calling helper functions form external modules #3918

Merged
merged 8 commits into from Aug 2, 2018

Conversation

Projects
None yet
2 participants
@gfr
Contributor

gfr commented Aug 1, 2018

Q A
Bug fix? yes
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets -
Refs tickets -
License MIT
Changelog updated [yes/no]

Description

Fixed wrong translation domain in templates when calling helper functions form external modules

Todos

  • Tests
  • Documentation
  • Changelog

gfr added some commits Aug 1, 2018

@Guite

This comment has been minimized.

Member

Guite commented Aug 2, 2018

  • please target 1.5 instead of master
  • please rebase to current 1.5

@gfr gfr changed the base branch from master to 1.5 Aug 2, 2018

gfr added some commits Aug 1, 2018

return $this->translator->__f('Welcome to %s!', ['%s' => $siteName]);
break;
return $this->translator->__f('Welcome to %s!', ['%s' => $siteName], 'zikula');
break;

This comment has been minimized.

@Guite

Guite Aug 2, 2018

Member

remove the space char

gfr added some commits Aug 2, 2018

Merge branch '1.5-mailerHelperTranslationDomain' of github.com:gfr/co…
…re into 1.5-mailerHelperTranslationDomain
Revert "Fixed coding style issues"
This reverts commit 5496490.

@Guite Guite added this to the 1.5.8 milestone Aug 2, 2018

@Guite Guite merged commit 1b4fb7c into zikula:1.5 Aug 2, 2018

2 of 4 checks passed

SensioLabsInsight Your analysis has been queued.
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
clahub All contributors have signed the Contributor License Agreement.
Details
continuous-integration/styleci/pr The analysis has passed
Details

@gfr gfr deleted the gfr:1.5-mailerHelperTranslationDomain branch Aug 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment