Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for textareas #4421

Merged
merged 3 commits into from Jul 24, 2020
Merged

fix for textareas #4421

merged 3 commits into from Jul 24, 2020

Conversation

craigh
Copy link
Member

@craigh craigh commented Jul 24, 2020

trying to fix minor layout issue for textareas. I am surprised bootstrap does not already solve this.

before:

Screen Shot 2020-07-24 at 11 09 35 AM

after:

Screen Shot 2020-07-24 at 11 23 28 AM

@craigh craigh added this to the 3.0.1 milestone Jul 24, 2020
@craigh craigh requested a review from Guite July 24, 2020 15:24
@craigh
Copy link
Member Author

craigh commented Jul 24, 2020

ahh. now I see that it is missing form-control class e.g. https://getbootstrap.com/docs/4.0/components/forms/#form-controls

@Guite
Copy link
Member

Guite commented Jul 24, 2020

Yes. Adding form-control solves this.

@craigh
Copy link
Member Author

craigh commented Jul 24, 2020

better fix:
Screen Shot 2020-07-24 at 11 43 04 AM

@craigh craigh merged commit b473f22 into master Jul 24, 2020
5 of 6 checks passed
@craigh craigh deleted the _textareafix branch July 24, 2020 15:57
craigh added a commit that referenced this pull request Jul 24, 2020
@craigh
fix for textareas (#4421)
44d1c6d 
* fix for textareas
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Guite Guite

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@craigh @Guite