Replace custom parameters with real symfony config #4433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigh
commented
Aug 3, 2020
Guite
approved these changes
Aug 3, 2020
craigh
changed the title
… DynamicConfigDumper. refactor to stop using those files and reduce usage of YamlDumper Installation should work. upgrade not sure yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The goal of this PR would be to replace all custom parameters in the
services_custom.yamlfile with appropriate configuration in core extensions/bundles using "real" symfony config.Ultimately, I'd like to remove the
services_custom.yamlcompletely since theservices.yamlfile is entirely custom anyway. I would also like to look at removing thedynamic/generated.yamlanddefaultfiles as well.This would all need some BC work so that 3.1.0 doesn't break existing installs, but I think this is quite doable.
Todos