Add rails5.1 #148
Merged
Add rails5.1 #148
+29
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syguer
commented
Apr 28, 2017
| @@ -35,7 +35,7 @@ def cache_key | |||
| if Object.const_defined?(:ActiveModel) | |||
| model_name.cache_key | |||
| else | |||
| ActiveSupport::Inflector.tableize(self).downcase | |||
| ActiveSupport::Inflector.tableize(self.name).downcase | |||
There was a problem hiding this comment.
I don't know why, but this code has been failed.
|
@syguer I currently have no projects that use active_hash. Is there something in particular that I can do, or are you asking me to just kick the tires? |
|
@kbrock Thanks for reply. just kick the tires please! |
|
need to get rid of quoted_id too see rails/rails#27962 (comment) |
|
@grosser Thanks for information. It seems to be just deprecated. Could you create an issue about your problem? |
|
here ya go: #150 |
|
@grosser thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails 5.1 has been released 🎉