Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate docs (fixes #212) #213
Merged
Conversation
| @@ -30,6 +30,7 @@ require 'sinatra/reloader' # for hot reloading changes we make | |||
| require_relative '../blog' | |||
| class Web < Sinatra::Base | |||
| enable :sessions | |||
This comment has been minimized.
This comment has been minimized.
|
|
||
| ```ruby | ||
| get '/authors/id/:aggregate_id' do | ||
| get '/authors/:aggregate_id' do |
This comment has been minimized.
This comment has been minimized.
lucascaton
Dec 21, 2019
Author
Contributor
I removed this from the author path to keep it consistent with Rails routes pattern.
Although this isn't Rails, I think it's nice to use something most of Ruby developers are used to it.
Hope it makes sense :)
| @@ -250,6 +250,8 @@ class AddAuthor < Sequent::Command | |||
| end | |||
| ``` | |||
|
|
|||
| And the `AuthorCommandHandler` to `config/initializers/sequent.rb`. | |||
This comment has been minimized.
This comment has been minimized.
lucascaton
Dec 21, 2019
Author
Contributor
This is a mandatory step and was missing, as reported via #212.
|
Thanks a lot @lucascaton! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
lucascaton commentedDec 21, 2019
Firstly, thanks for providing a helpful documentation to help people to get started.
I've improved the docs a little bit and also fixed the issue #212.
There's more details in the commit messages of this PR.
Hope my changes make sense :)