zilverline / sequent Public
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs (fixes #212) #213
Conversation
@@ -30,6 +30,7 @@ require 'sinatra/reloader' # for hot reloading changes we make | |||
require_relative '../blog' | |||
class Web < Sinatra::Base | |||
enable :sessions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is necessary to get Sinatra::Flash
working.
|
||
```ruby | ||
get '/authors/id/:aggregate_id' do | ||
get '/authors/:aggregate_id' do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this from the author path to keep it consistent with Rails routes pattern.
Although this isn't Rails, I think it's nice to use something most of Ruby developers are used to it.
Hope it makes sense :)
@@ -250,6 +250,8 @@ class AddAuthor < Sequent::Command | |||
end | |||
``` | |||
|
|||
And the `AuthorCommandHandler` to `config/initializers/sequent.rb`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a mandatory step and was missing, as reported via #212.
Firstly, thanks for providing a helpful documentation to help people to get started.
I've improved the docs a little bit and also fixed the issue #212.
There's more details in the commit messages of this PR.
Hope my changes make sense :)