Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs (fixes #212) #213

Merged
merged 5 commits into from Dec 24, 2019
Merged

Update docs (fixes #212) #213

merged 5 commits into from Dec 24, 2019

Conversation

lucascaton
Copy link
Contributor

@lucascaton lucascaton commented Dec 21, 2019

Firstly, thanks for providing a helpful documentation to help people to get started.

I've improved the docs a little bit and also fixed the issue #212.
There's more details in the commit messages of this PR.

Hope my changes make sense :)

@@ -30,6 +30,7 @@ require 'sinatra/reloader' # for hot reloading changes we make
require_relative '../blog'
class Web < Sinatra::Base
enable :sessions
Copy link
Contributor Author

@lucascaton lucascaton Dec 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is necessary to get Sinatra::Flash working.


```ruby
get '/authors/id/:aggregate_id' do
get '/authors/:aggregate_id' do
Copy link
Contributor Author

@lucascaton lucascaton Dec 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this from the author path to keep it consistent with Rails routes pattern.

Although this isn't Rails, I think it's nice to use something most of Ruby developers are used to it.

Hope it makes sense :)

@@ -250,6 +250,8 @@ class AddAuthor < Sequent::Command
end
```

And the `AuthorCommandHandler` to `config/initializers/sequent.rb`.
Copy link
Contributor Author

@lucascaton lucascaton Dec 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a mandatory step and was missing, as reported via #212.

lvonk
lvonk approved these changes Dec 24, 2019
Copy link
Member

@lvonk lvonk left a comment

Thanks a lot @lucascaton!

@lvonk lvonk merged commit 51fd3a3 into zilverline:master Dec 24, 2019
2 checks passed
@lucascaton lucascaton deleted the update-docs branch Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants