From b502467c5c27ec84ae2f0cd64256963f3d26de45 Mon Sep 17 00:00:00 2001 From: Simeon Warner Date: Sat, 5 Dec 2015 17:32:05 -0500 Subject: [PATCH] Sort header keys when making message --- iiif/error.py | 5 +++-- tests/test_error.py | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/iiif/error.py b/iiif/error.py index 22f0edd..bdee6f1 100644 --- a/iiif/error.py +++ b/iiif/error.py @@ -107,7 +107,7 @@ def as_txt(self): s += "parameter=%s\n" % self.parameter if (self.code): s += "code=%d\n\n" % self.code - for header in self.headers: + for header in sorted(self.headers): s += "header %s=%s\n" % (header,self.headers[header]) return s @@ -115,7 +115,8 @@ def __str__(self): """Default human readable version of IIIF error. Intention is that image server implementations will use - image_server_response(api_version) instead + image_server_response(api_version) instead. Does not include + header values in output """ s = self.text if (self.text) else 'UNKNOWN_ERROR' if (self.parameter): diff --git a/tests/test_error.py b/tests/test_error.py index 6bd07d2..a7a770a 100644 --- a/tests/test_error.py +++ b/tests/test_error.py @@ -30,7 +30,7 @@ def test03_txt(self): e = IIIFError() msg = 'IIIF Image Server Error\n\nself.text\n\nparameter=unknown\ncode=500\n\n' self.assertEqual( e.as_txt(), msg ) - e = IIIFError(headers={'a':'b','cc':'dd'}) + e = IIIFError(headers={'cc':'dd','a':'b'}) self.assertEqual( e.as_txt(), msg + 'header a=b\nheader cc=dd\n') def test04_image_server_response(self):