From dc5207a9dc03e9f87d220d0cdf9b3654af5aa8ef Mon Sep 17 00:00:00 2001
From: Christian Budde Christensen <budde377@gmail.com>
Date: Sat, 13 Aug 2022 08:56:05 +0100
Subject: [PATCH] fix(graphql): Normalization signature

---
 packages/graphql/lib/src/cache/_normalizing_data_proxy.dart | 6 +++---
 .../graphql/lib/src/cache/_optimistic_transactions.dart     | 4 ++--
 packages/graphql/lib/src/cache/data_proxy.dart              | 4 ++--
 3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/packages/graphql/lib/src/cache/_normalizing_data_proxy.dart b/packages/graphql/lib/src/cache/_normalizing_data_proxy.dart
index a47e2a94..549a3c6b 100644
--- a/packages/graphql/lib/src/cache/_normalizing_data_proxy.dart
+++ b/packages/graphql/lib/src/cache/_normalizing_data_proxy.dart
@@ -65,7 +65,7 @@ abstract class NormalizingDataProxy extends GraphQLDataProxy {
   /// The key differentiating factor for an implementing `cache` or `proxy`
   /// is usually how they handle [optimistic] reads.
   @protected
-  Map<String, dynamic>? readNormalized(String rootId, {bool? optimistic});
+  Map<String, dynamic>? readNormalized(String rootId, {bool optimistic});
 
   /// Write normalized data into the cache.
   ///
@@ -80,7 +80,7 @@ abstract class NormalizingDataProxy extends GraphQLDataProxy {
 
   Map<String, dynamic>? readQuery(
     Request request, {
-    bool? optimistic = true,
+    bool optimistic = true,
   }) =>
       denormalizeOperation(
         // provided from cache
@@ -100,7 +100,7 @@ abstract class NormalizingDataProxy extends GraphQLDataProxy {
 
   Map<String, dynamic>? readFragment(
     FragmentRequest fragmentRequest, {
-    bool? optimistic = true,
+    bool optimistic = true,
   }) =>
       denormalizeFragment(
         // provided from cache
diff --git a/packages/graphql/lib/src/cache/_optimistic_transactions.dart b/packages/graphql/lib/src/cache/_optimistic_transactions.dart
index 737603a5..19a9b6b7 100644
--- a/packages/graphql/lib/src/cache/_optimistic_transactions.dart
+++ b/packages/graphql/lib/src/cache/_optimistic_transactions.dart
@@ -59,8 +59,8 @@ class OptimisticProxy extends NormalizingDataProxy {
 
   @override
   Map<String, dynamic>? readNormalized(String rootId,
-      {bool? optimistic = true}) {
-    if (!optimistic!) {
+      {bool optimistic = true}) {
+    if (!optimistic) {
       return cache.readNormalized(rootId, optimistic: false);
     }
     // the cache calls `patch.data.containsKey(rootId)`,
diff --git a/packages/graphql/lib/src/cache/data_proxy.dart b/packages/graphql/lib/src/cache/data_proxy.dart
index 5dfad1db..53f0f13f 100644
--- a/packages/graphql/lib/src/cache/data_proxy.dart
+++ b/packages/graphql/lib/src/cache/data_proxy.dart
@@ -98,7 +98,7 @@ import './fragment.dart';
 /// ```
 abstract class GraphQLDataProxy {
   /// Reads a GraphQL query from the root query id.
-  Map<String, dynamic>? readQuery(Request request, {bool? optimistic});
+  Map<String, dynamic>? readQuery(Request request, {bool optimistic});
 
   /// Reads a GraphQL fragment from any arbitrary id.
   ///
@@ -107,7 +107,7 @@ abstract class GraphQLDataProxy {
   /// to select the correct fragment.
   Map<String, dynamic>? readFragment(
     FragmentRequest fragmentRequest, {
-    bool? optimistic,
+    bool optimistic,
   });
 
   /// Writes a GraphQL query to the root query id,