Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Join forces #5
I have to think about to merge everything into webdrivercss. Currently, I think it's better to seperate webdrivercss into multiple packages as suggested in webdriverio-boneyard/webdrivercss#113.
Webdrivercss does at the moment many different things:
I tried this transformation with wdio-screenshot and wdio-visual-regression-service.
Anyway, I'm with you that the projects will definitely benefit from each other.
What do you think about the separation into multiple packages? Are there any drawbacks?
Sorry for getting back to you so late.
Yeah this is the plan. Ultimately it would be great to see similar modular structure like in WebdriverIO where you can apply reporters and service as you want. For example let's have data store addons to save images on the file system, on dropbox or any other arbitrary server. A different type of addon could be the comparison mechanism. Options are pixel by pixel, gm and applitools. Each one of these plugins could live in its own repository.
Question is: do we want to have another organization for webdrivercss or is it ok to put it there? Also is wdio-screenshot only the screenshot taker and webdrivercss should manage this whole plugin system? What do you think about this plugin system?
That's what I already tried with wdio-visual-regression-service. It's responsible for taking screenshots with
Such a method is just a simple implementation of 4 different hooks:
At the moment I just implemented a LocalCompare method which just stores screenshots locally and compares them against some reference shots.
What do mean with "put it there"? WebdriverIO?
That was my plan. My personal opinion is that the screenshot taking functionality is so complex that it should exist on it's own. This makes it also easier to use it for other projects, too.
This service only works if you run it with the wdio testrunner. Something that would be great is that we provide VRT functionality for standalone as well as for testrunner mode. This would allow 3rd party libraries like Spectron or Concept to leverage from it. I would almost say that the service could be the next version of WebdriverCSS if we change it to work as a plugin not as a service. However I don't want to do that if you don't want that. I just think that more people know WebdriverCSS as that VRT tool for WebdriverIO.
I believe we get more user traktion if we have a GitHub organization for all plugins and tools around VRT with WebdriverIO. Maybe we can just keep it under the WebdriverIO org hat. But like I said, if you would rather want continue this under your account that is fine too.
I absolutely agree. One of the reason why I stand off of it. It took too much time for me to fix all the issues especially on mobile.
Sounds good to me.
Makes sense. I'm definitely open for this.
Question is: Does it make sense to create another organization for this? Another organization just for regression testing gives us probably a better overview. But this dependents on the planned features/plugins. I think we can keep everything as it is until the roadmap is clear.
As next step we should start collecting some ideas. Don't know what's the best way to do this.