Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translate to NDBC Context #1865

Merged
merged 2 commits into from Jun 3, 2020
Merged

Conversation

juliano
Copy link
Collaborator

@juliano juliano commented May 24, 2020

Problem

Ndbc doesn't have translate

Solution

NdbcContext extends TranslateContextBase now.

Notes

Additional notes.

Checklist

  • Unit test all changes
  • Update README.md if applicable
  • Add [WIP] to the pull request title if it's work in progress
  • Squash commits that aren't meaningful changes
  • Run sbt scalariformFormat test:scalariformFormat to make sure that the source files are formatted

@getquill/maintainers

@juliano juliano merged commit 5132cc6 into zio:master Jun 3, 2020
1 check passed
@juliano juliano deleted the ndbc-translate-context branch Jun 3, 2020
zhrebicek pushed a commit to zhrebicek/quill that referenced this issue Aug 6, 2020
Co-authored-by: Alexander Ioffe <deusaquilus@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants