Bump to ZIO 2.0.0 Release Version #2511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deusaquilus
force-pushed
the
zio2-final
branch
5 times, most recently
from
6f1bf4e
to
f351a55
Compare
counter2015
reviewed
Nov 3, 2022
| @@ -163,13 +166,12 @@ abstract class ZioJdbcUnderlyingContext[Dialect <: SqlIdiom, Naming <: NamingStr | |||
| case Some(size) => | |||
| ZStream.fromIterator(iter, size) | |||
| case None => | |||
| Stream.fromIterator(new ResultSetIterator(rs, conn, extractor)) | |||
| ZStream.fromIterator(new ResultSetIterator(rs, conn, extractor)) | |||
There was a problem hiding this comment.
Why here construct another ResultSetIterator, can we just use iter here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump to ZIO 2.0.0 Release Version