Add ZStrem#zip left and right operators and alias for all zip operators #1510

jadireddi · 2019-08-28T11:55:53Z

Adding ZStrem#zipLeft and zipRight operators and operator alias for all ZStream#zip* functions.

iravid · 2019-08-28T12:03:56Z

Hi @jadireddi, thanks for picking this up. I updated the original issue - could you follow the requirements there? Thanks!

iravid · 2019-08-30T14:29:38Z

streams/shared/src/main/scala/zio/stream/ZStream.scala

@@ -1793,6 +1793,54 @@ class ZStream[-R, +E, +A](val process: ZManaged[R, E, Pull[R, E, A]]) extends Se
   */
  final def zipWithIndex: ZStream[R, E, (A, Int)] =
    mapAccum(0)((index, a) => (index + 1, (a, index)))
+
+  /**
+   * Runs this stream with the specified stream sequentially.


Suggested change

* Runs this stream with the specified stream sequentially.

* Composes this stream with the specified stream to create a cartesian product of elements. The `that`

stream would be run multiple times, for every element in the `this` stream.

See also [[ZStream#zip]] and [[ZStream#<&>]] for the more common point-wise variant.

iravid · 2019-08-30T14:30:32Z

streams/shared/src/main/scala/zio/stream/ZStream.scala

+    self.flatMap(ls => that.map(rs => (ls, rs)))
+
+  /**
+   * Runs this stream with the specified stream sequentially and keeps only values of this stream.


Suggested change

* Runs this stream with the specified stream sequentially and keeps only values of this stream.

* Composes this stream with the specified stream to create a cartesian product of elements, and keeps only

the elements from the `that` stream.

The `that` stream would be run multiple times, for every element in the `this` stream.

See also [[ZStream#zipWith]] and [[ZStream#<&>]] for the more common point-wise variant.

iravid · 2019-08-30T14:30:47Z

streams/shared/src/main/scala/zio/stream/ZStream.scala

+  /**
+   * Runs this stream with the specified stream sequentially and keeps only values of this stream.
+   */
+  final def <*[R1 <: R, E1 >: E, B](that: ZStream[R1, E1, B]): ZStream[R1, E1, A] =


Suggested change

final def <*[R1 <: R, E1 >: E, B](that: ZStream[R1, E1, B]): ZStream[R1, E1, A] =

* Composes this stream with the specified stream to create a cartesian product of elements, and keeps only

the elements from the `this` stream.

The `that` stream would be run multiple times, for every element in the `this` stream.

See also [[ZStream#zipWith]] and [[ZStream#<&>]] for the more common point-wise variant.

iravid · 2019-09-01T11:03:57Z

@jadireddi Could you also add the cross / crossWith named methods? I've edited the description for the original issue.

…O-1496-Zstream_zip_operators # Conflicts: # streams/shared/src/main/scala/zio/stream/ZStream.scala

jadireddi · 2019-09-02T03:32:59Z

@iravid , Fixed the review comments. Kindly review them.

…O-1496-Zstream_zip_operators

jadireddi · 2019-09-07T12:13:55Z

@iravid , Could you please review the code and let me know if any changes needed.

iravid

Thank you @jadireddi!

…, &> (zio#1510) * Add ZStrem#zip left and right operators and alias for all zip operators * formatted code to make scalafmtCheck pass. * change for <*> variants with flatmap and <&> with zipWith. * adding crossWith and cross functions to ZStream. * merge conflict change. * formatted naming conventions.

* implement permits * make TRef state private * prototype safe semaphore * implement permits * make TRef state private * #1219 - add doUntilEquals and doWhileEquals methods (#1634) * Update zio-interop-reactivestreams to 1.0.3.1-RC1 (#1665) * Add ZStream#cross, crossWith, <*>, <*, *>, <&>, zipLeft, zipRight, <&, &> (#1510) * Add ZStrem#zip left and right operators and alias for all zip operators * formatted code to make scalafmtCheck pass. * change for <*> variants with flatmap and <&> with zipWith. * adding crossWith and cross functions to ZStream. * merge conflict change. * formatted naming conventions. * Update the encoding of ZSink (#1560) * prototype safe semaphore * cleanup * uodate documentation * address review comments * cleanup * add back and deprecate methods * cleanup * make method private

* implement permits * make TRef state private * prototype safe semaphore * implement permits * make TRef state private * zio#1219 - add doUntilEquals and doWhileEquals methods (zio#1634) * Update zio-interop-reactivestreams to 1.0.3.1-RC1 (zio#1665) * Add ZStream#cross, crossWith, <*>, <*, *>, <&>, zipLeft, zipRight, <&, &> (zio#1510) * Add ZStrem#zip left and right operators and alias for all zip operators * formatted code to make scalafmtCheck pass. * change for <*> variants with flatmap and <&> with zipWith. * adding crossWith and cross functions to ZStream. * merge conflict change. * formatted naming conventions. * Update the encoding of ZSink (zio#1560) * prototype safe semaphore * cleanup * uodate documentation * address review comments * cleanup * add back and deprecate methods * cleanup * make method private

Add ZStrem#zip left and right operators and alias for all zip operators

cb210d3

jadireddi added 2 commits August 28, 2019 17:47

formatted code to make scalafmtCheck pass.

c4690d5

change for <*> variants with flatmap and <&> with zipWith.

7262dfc

iravid reviewed Aug 30, 2019

View reviewed changes

jadireddi added 3 commits September 2, 2019 01:09

adding crossWith and cross functions to ZStream.

7fa2a7b

Merge branch 'master' of https://github.com/scalaz/scalaz-zio into ZI…

fc99dc4

…O-1496-Zstream_zip_operators # Conflicts: # streams/shared/src/main/scala/zio/stream/ZStream.scala

merge conflict change.

e292f6d

jadireddi added 2 commits September 2, 2019 09:34

formatted naming conventions.

f20b5e9

Merge branch 'master' of https://github.com/scalaz/scalaz-zio into ZI…

9dc6960

…O-1496-Zstream_zip_operators

iravid approved these changes Sep 13, 2019

View reviewed changes

iravid merged commit d7df03e into zio:master Sep 13, 2019

ghostdogpr mentioned this pull request Sep 13, 2019

Add zipLeft, zipRight methods (as addition to zip method) to ZStream and equivalent operators #1496

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ZStrem#zip left and right operators and alias for all zip operators #1510

Add ZStrem#zip left and right operators and alias for all zip operators #1510

jadireddi commented Aug 28, 2019

iravid commented Aug 28, 2019

iravid Aug 30, 2019 •

edited

jadireddi Sep 2, 2019

iravid Aug 30, 2019

jadireddi Sep 2, 2019

iravid Aug 30, 2019

jadireddi Sep 2, 2019

iravid commented Sep 1, 2019

jadireddi commented Sep 2, 2019

jadireddi commented Sep 7, 2019

iravid left a comment

-   * Runs this stream with the specified stream sequentially.
+   * Composes this stream with the specified stream to create a cartesian product of elements. The `that`
+     stream would be run multiple times, for every element in the `this` stream.
+     See also [[ZStream#zip]] and [[ZStream#<&>]] for the more common point-wise variant.

-   * Runs this stream with the specified stream sequentially and keeps only values of this stream.
+   * Composes this stream with the specified stream to create a cartesian product of elements, and keeps only
+     the elements from the `that` stream.
+     The `that` stream would be run multiple times, for every element in the `this` stream.
+     See also [[ZStream#zipWith]] and [[ZStream#<&>]] for the more common point-wise variant.

Add ZStrem#zip left and right operators and alias for all zip operators #1510

Add ZStrem#zip left and right operators and alias for all zip operators #1510

Conversation

jadireddi commented Aug 28, 2019

iravid commented Aug 28, 2019

iravid Aug 30, 2019 • edited

Choose a reason for hiding this comment

jadireddi Sep 2, 2019

Choose a reason for hiding this comment

iravid Aug 30, 2019

Choose a reason for hiding this comment

jadireddi Sep 2, 2019

Choose a reason for hiding this comment

iravid Aug 30, 2019

Choose a reason for hiding this comment

jadireddi Sep 2, 2019

Choose a reason for hiding this comment

iravid commented Sep 1, 2019

jadireddi commented Sep 2, 2019

jadireddi commented Sep 7, 2019

iravid left a comment

Choose a reason for hiding this comment

iravid Aug 30, 2019 •

edited