Adapt ZIO.someOrFailException to improve interop with error types
#2087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlangc
force-pushed
the
fix-some-or-fail
branch
from
9289a4a
to
fa20893
Compare
iravid
approved these changes
Nov 11, 2019
|
Thanks @mlangc! |
Twizty
pushed a commit
to Twizty/zio
that referenced
this pull request
Nov 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adapts the signature of
ZIO.someOrFailExceptionto better work with commonly used error types likeThrowable. For example, without this PR,does not compile, but with this PR, it does.
Something that does not yet compile is
(io: IO[E, Option[A]]).someOrFailExceptionifEis not a supertype ofNoSuchElementException, like(io: IO[IllegalArgumentException, Option[A]]).someOrFailException. Ideally, this should work, with the error type of the result being the most specific common supertype ofEandNoSuchElementException, but I didn't yet find a way to achieve this.In any way, this PR is an improvement over the existing state of affairs.