Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new BoolAlgebra.all operator #3857

Merged
merged 3 commits into from Jul 16, 2020
Merged

new BoolAlgebra.all operator #3857

merged 3 commits into from Jul 16, 2020

Conversation

fokot
Copy link
Contributor

@fokot fokot commented Jun 23, 2020

I just found it useful to write

BoolAlgebra.all(
        assert(created)(isTrue),
        assert(deleted)(isTrue),
        assert(notDeleted)(isFalse)
)

And not to work with Iterable and Option

@CLAassistant
Copy link

CLAassistant commented Jun 23, 2020 •
edited

CLA assistant check
All committers have signed the CLA.

adamgfraser
adamgfraser previously approved these changes Jun 24, 2020
View reviewed changes
Copy link
Contributor

@adamgfraser adamgfraser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. We could also do the same thing with any. I wonder if we should just move all of these methods to take a non-empty collection.

fokot
fokot commented Jun 29, 2020
View reviewed changes
Copy link
Contributor Author

@fokot fokot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamgfraser I added any operator

@adamgfraser
Copy link
Contributor

@fokot Thanks! Can you merge upstream changes and sign the CLA?

@fokot
Copy link
Contributor Author

fokot commented Jun 30, 2020

Sure, can you @adamgfraser approve it so I can merge it?

@adamgfraser adamgfraser merged commit a7c4dad into zio:master Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamgfraser adamgfraser adamgfraser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fokot @CLAassistant @adamgfraser