Fix Potential Nontermination When Layer Fails With Error #3994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iravid
reviewed
Jul 22, 2020
| @@ -2858,8 +2858,8 @@ object ZIO extends ZIOCompanionPlatformSpecific { | |||
| .forkManaged | |||
| _ <- interrupter.use_ { | |||
| ZIO | |||
| .whenM(result.await.map(!_)) { | |||
| causes.get.flatMap(ZIO.halt(_)) | |||
| .whenM(ZIO.foreach(fibers)(_.await).map(_.exists(!_.succeeded))) { | |||
There was a problem hiding this comment.
Nothing is awaiting the result with this change. Is it still required?
There was a problem hiding this comment.
You're right. Deleted the old result and renamed failureTrigger to result.
iravid
approved these changes
Jul 22, 2020
|
Yes. I think that may require additional combinators because child fibers may never run at all if the scope is already closed so they may not be able to signal that the task is completed. |
|
Makes sense! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3956.
The issue is that if the scope is already closed in
ZIO#foreachPar_the forked effects will never run and will never complete the promise, resulting in non-termination.Also restores the changes to remove the by name parameters from ZLayer to address early initialization issues.
Note that this PR is not binary compatible.