Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inflection bug #261

Closed
wants to merge 2 commits into from
Closed

Fix inflection bug #261

wants to merge 2 commits into from

Conversation

dcadenas
Copy link

If you happen to have an inflection acronym that partially matches one of the uppercase formatted headers as shown in this test then the doc generated outputs broken headers.

This pull request substitutes titleize so that header generation can't be accidentally changed by Rails inflections.

@oestrich
Copy link
Contributor

Can you add a spec that would fail without this change? I'm not sure what this is fixing right now.

@dcadenas
Copy link
Author

Eric if you run the modified spec in the PR without applying the fix it
will fail. The only change I had to add to the spec to make it fail was the
inflector acronym shown at the top of the file.

If you have an acronym like "AC" in the Rails inflectors acronyms list it
would break the ACCEPT header when rendering the doc. It generates "AC
Cept" because titleize sees "AC" in that string and it thinks it's and
acronym.

On Tue, Feb 16, 2016 at 6:17 PM, Eric Oestrich notifications@github.com
wrote:

Can you add a spec that would fail without this change? I'm not sure what
this is fixing right now.


Reply to this email directly or view it on GitHub
#261 (comment)
.

@oestrich
Copy link
Contributor

Closing due to age.

@oestrich oestrich closed this Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants