New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatible socket.io-redis 0.2, but not compatible socket.io-redis 0.1 #12

Merged
merged 4 commits into from Jan 14, 2016

Conversation

Projects
None yet
3 participants
@GameXG
Contributor

GameXG commented Dec 8, 2015

Realization #11

GameXG added some commits Dec 8, 2015

@@ -59,7 +58,14 @@ def Emit(self, *args):
rooms = self._getRooms()
extras['rooms'] = rooms if len(rooms) > 0 else ''
self._client.publish(self._key, msgpack.packb([packet, extras]))
self._client.publish(self._key + "#emitter", msgpack.packb([packet, extras]))

This comment has been minimized.

@ashiina

ashiina Dec 29, 2015

This line should be deleted.

  • for socket.io-redis >= 0.2.0 , it is unnecessary.
  • for socket.io-redis < 0.2.0 , socket.io will receive TWO messages (one from line61, and one from line65~68).

This comment has been minimized.

@GameXG

GameXG Dec 29, 2015

Contributor

Send duplicate indeed not a good idea.
But if socket.io-redis < 0.2 not will receive TWO messages。 See # 11

socket.io change protocol is a hassle.

ziyasal added a commit that referenced this pull request Jan 14, 2016

Merge pull request #12 from GameXG/master
Compatible socket.io-redis 0.2, but not compatible socket.io-redis 0.1

@ziyasal ziyasal merged commit 208ff96 into ziyasal:master Jan 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment