New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change package config directories #12

Merged
merged 1 commit into from May 28, 2018

Conversation

Projects
None yet
2 participants
@WildGunman
Contributor

WildGunman commented May 8, 2018

The preferred name for this package, and by extension its hard-coded installation path, appears to be "Stata Improved Editor" rather than "MacStataEditor". Since this is how Package Control installs the package directory hooks for the config and keymap files, the config menus and defaults are broken when installed since they point to a non-existent directory. Diagnosing this is somewhat mysterious to a new ST user.

Since the preferred installation language seems to be "Stata Improved Editor," I changed package config directories from "MacStataEditor" to "Stata Improved Editor" in order to properly harmonize with Package Control distribution. Your preference may actually be to change the naming convention in Package Control, but then the Readme instructions for manual installation should probably harmonized to that.

Change package config directories
Changed package config directories from "MacStataEditor" to "Stata Improved Editor" in order to properly harmonize with Package Control distribution.
@zizhongyan

This comment has been minimized.

Owner

zizhongyan commented May 28, 2018

That's great. thank you very much! I would merge the pull request.

@zizhongyan zizhongyan merged commit a64ef77 into zizhongyan:master May 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment