Skip to content

Detect shell before applying template expression fixes - #1064

Merged
woodruffw merged 6 commits into
zizmorcore:mainfrom
mostafa:fix-shell-detection
Aug 9, 2025
Merged

woodruffw merged 6 commits into
zizmorcore:mainfrom
mostafa:fix-shell-detection

Conversation

@mostafa

@mostafa mostafa commented Aug 7, 2025 •

Copy link
Copy Markdown
Contributor

This PR fixes #1049 by detecting all the supported shells except Python and applying the correct environment variable syntax for fixing the finding(s), according to GitHub workflow syntax.

@kusari-inspector

kusari-inspector Bot commented Aug 7, 2025 •

Copy link
Copy Markdown

Kusari Analysis Results

Analysis for commit: d21563d, performed at: 2025-08-09T05:52:12Z

• @kusari-inspector rerun - Trigger a re-analysis of this PR

• @kusari-inspector feedback [your message] - Send feedback to our AI and team


Recommendation

✅ PROCEED with this Pull Request

Summary

✅ No Flagged Issues Detected

All values appear to be within acceptable risk parameters.

No pinned version dependency changes, code issues or exposed secrets detected!

Found this helpful? Give it a 👍 or 👎 reaction!

@funnelfiasco funnelfiasco added the bugfix Fixes a known bug label Aug 7, 2025
@kusari-inspector

Copy link
Copy Markdown

Kusari PR Analysis rerun based on - a13a0f8 performed at: 2025-08-08T12:16:06Z - link to updated analysis

Comment thread crates/zizmor/src/models.rs Resolved
@kusari-inspector

Copy link
Copy Markdown

Kusari PR Analysis rerun based on - 034e168 performed at: 2025-08-08T14:24:16Z - link to updated analysis

@kusari-inspector

Copy link
Copy Markdown

Kusari PR Analysis rerun based on - 0efd7d9 performed at: 2025-08-09T05:45:13Z - link to updated analysis

@woodruffw woodruffw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mostafa, this looks great to me!

@woodruffw
woodruffw enabled auto-merge (squash) August 9, 2025 05:46
@woodruffw
woodruffw disabled auto-merge August 9, 2025 05:47
@kusari-inspector

Copy link
Copy Markdown

Kusari PR Analysis rerun based on - d21563d performed at: 2025-08-09T05:52:12Z - link to updated analysis

@woodruffw
woodruffw merged commit ea59c81 into zizmorcore:main Aug 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Fixes a known bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: Auto-fixes for template-injection are incorrect on non-sh shells

3 participants