Skip to content

Add Fix to imposter-commit audit rule - #1090

Merged
woodruffw merged 11 commits into
zizmorcore:mainfrom
mostafa:imposter-commit-fix
Oct 6, 2025
Merged

Add Fix to imposter-commit audit rule#1090
woodruffw merged 11 commits into
zizmorcore:mainfrom
mostafa:imposter-commit-fix

Conversation

@mostafa

@mostafa mostafa commented Aug 16, 2025

Copy link
Copy Markdown
Contributor

This PR adds auto-fixes to the imposter-commit audit rule with online tests.

@kusari-inspector

kusari-inspector Bot commented Aug 16, 2025

Copy link
Copy Markdown

Kusari Inspector

Kusari Analysis Results:

Proceed with these changes

✅ No Flagged Issues Detected
All values appear to be within acceptable risk parameters.

No pinned version dependency changes, code issues or exposed secrets detected!

Note

View full detailed analysis result for more information on the output and the checks that were run.


@kusari-inspector rerun - Trigger a re-analysis of this PR
@kusari-inspector feedback [your message] - Send feedback to our AI and team
See Kusari's documentation for setup and configuration.
Commit: 9e90f17, performed at: 2025-10-06T01:14:29Z

Found this helpful? Give it a 👍 or 👎 reaction!

@kusari-inspector

Copy link
Copy Markdown

Kusari PR Analysis rerun based on - 0d33dd2 performed at: 2025-08-16T20:44:11Z - link to updated analysis

@kusari-inspector

Copy link
Copy Markdown

Kusari PR Analysis rerun based on - 1e03428 performed at: 2025-09-16T03:03:09Z - link to updated analysis

@mostafa

mostafa commented Sep 30, 2025

Copy link
Copy Markdown
Contributor Author

@woodruffw Any updates here?

@woodruffw

Copy link
Copy Markdown
Member

@woodruffw Any updates here?

Nope, I need to do another review pass. My plan is to get to it tonight.

Comment thread crates/zizmor/src/audit/impostor_commit.rs Outdated
Comment thread crates/zizmor/src/audit/impostor_commit.rs
Comment thread crates/zizmor/src/audit/impostor_commit.rs
Comment thread crates/zizmor/src/audit/impostor_commit.rs
Comment thread crates/zizmor/src/audit/impostor_commit.rs Outdated
@kusari-inspector

Copy link
Copy Markdown

Kusari PR Analysis rerun based on - 4ba38ef performed at: 2025-10-01T09:41:30Z - link to updated analysis

@kusari-inspector

Copy link
Copy Markdown

Kusari PR Analysis rerun based on - 16e6cff performed at: 2025-10-06T01:05:11Z - link to updated analysis

Signed-off-by: William Woodruff <william@yossarian.net>
@woodruffw woodruffw added enhancement New feature or request autofix Auto-fix functionality labels Oct 6, 2025
@kusari-inspector

Copy link
Copy Markdown

Kusari PR Analysis rerun based on - 51a1c0f performed at: 2025-10-06T01:05:41Z - link to updated analysis

Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
@kusari-inspector

Copy link
Copy Markdown

Kusari PR Analysis rerun based on - 9e90f17 performed at: 2025-10-06T01:14:29Z - link to updated analysis

@woodruffw woodruffw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mostafa!

Thinking out loud: technically this won't produce a fixpoint with ref-version-mismatch, since our edit here won't also edit the version comment (if present). I think that's OK for now since this is an "unsafe" fix.

@woodruffw
woodruffw merged commit 587bd72 into zizmorcore:main Oct 6, 2025
10 checks passed
@mostafa
mostafa deleted the imposter-commit-fix branch October 6, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autofix Auto-fix functionality enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants