fix: exclude information about the repo and owner - #136
Conversation
This would seem to fall into the category of "if these values are unsafe, we have bigger problems to deal with" Signed-off-by: Ben Cotton <ben@kusari.dev>
|
Thanks @funnelfiasco! I think this is going to be similar to #128 -- excluding (AFAIK repo/owner information is probably safe, but URL quoting/escaping isn't always super consistent, and there may be funny things that someone can do with Enterprise deployment URLs.) |
|
Of course GitHub doesn't provide documentation on what's actually possible, but in the case of these values there's nothing an attacker could do to modify them. So even if it's possible and someone names their repository |
I think that's right, except for in the fork context -- in that context the attacker controls all of these, but I agree that there's still no injection risk with them (I suppose someone could name their GitHub account Given that, I'm good with this. Thanks for the PR! |
This would seem to fall into the category of "if these values are unsafe, we have bigger problems to deal with"