Repository navigation
feat: improve forbidden-uses error message on invalid config - #1381
Merged
Merged
Conversation
Signed-off-by: William Woodruff <william@yossarian.net>
woodruffw
added
enhancement
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Member
Author
|
This is also probably slightly faster, since we no longer have to perform exhaustive enum matching. But the performance difference doesn't matter at all given that config loading isn't a hot path at all + there are only two variants here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our previous use of
untaggedmeant that we'd swallow our actual underlying error and replace it with a generic "no variants matched" error, which is not super useful to users.We now employ a minor hack to get JSON style tagged enums to work with serge-yaml, which changed its behavior on 0.9 to default to YAML style explicit tagging (which we do not want).