Skip to content

Fix singular and plural for 'findings' - #162

Merged
woodruffw merged 1 commit into
zizmorcore:mainfrom
hugovk:main
Nov 16, 2024
Merged

woodruffw merged 1 commit into
zizmorcore:mainfrom
hugovk:main

Conversation

@hugovk

@hugovk hugovk commented Nov 16, 2024

Copy link
Copy Markdown
Contributor

Fix "1 findings" -> "1 finding" and keep "2 findings".

Before

zizmor .
🌈 completed main.yml
🌈 completed deploy.yml
🌈 completed lint.yml
warning[artipacked]: credential persistence through GitHub Actions artifacts
  --> /Users/hugo/github/cherry-picker/.github/workflows/lint.yml:16:9
   |
16 |       - uses: actions/checkout@v4
   |         ------------------------- does not set persist-credentials: false
   |
   = note: audit confidence → Low

1 findings: 0 unknown, 0 informational, 0 low, 1 medium, 0 high

After

/tmp/zizmor/target/debug/zizmor .
🌈 completed lint.yml
🌈 completed main.yml
🌈 completed deploy.yml
warning[artipacked]: credential persistence through GitHub Actions artifacts
  --> /Users/hugo/github/cherry-picker/.github/workflows/lint.yml:16:9
   |
16 |       - uses: actions/checkout@v4
   |         ------------------------- does not set persist-credentials: false
   |
   = note: audit confidence → Low

1 finding: 0 unknown, 0 informational, 0 low, 1 medium, 0 high

@woodruffw woodruffw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hugovk!

@woodruffw
woodruffw enabled auto-merge (squash) November 16, 2024 16:09
@woodruffw
woodruffw merged commit b9b6e26 into zizmorcore:main Nov 16, 2024
@woodruffw woodruffw added the enhancement New feature or request label Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants