feat: adds support to inlined ignores#187
Merged
Merged
Conversation
woodruffw
reviewed
Nov 22, 2024
Member
|
Thanks @ubiratansoares! I like the (Apologies for the merge, that was a force of habit. If it makes things annoying here, please feel free to force-push over it.) |
woodruffw
reviewed
Nov 22, 2024
woodruffw
reviewed
Nov 22, 2024
woodruffw
reviewed
Nov 22, 2024
woodruffw
reviewed
Nov 22, 2024
a387aa7 to
0de3177
Compare
woodruffw
reviewed
Nov 23, 2024
woodruffw
reviewed
Nov 23, 2024
woodruffw
left a comment
Member
There was a problem hiding this comment.
Thanks @ubiratansoares!
I think I'd like to see #187 (comment) in this PR, but otherwise everything looks fantastic to me (and we can start follow-up issues/PRs for the other things).
0de3177 to
0edaf5b
Compare
woodruffw
reviewed
Nov 23, 2024
This was referenced Nov 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #124
There are 2 approaches here
FindingRegistrylevelFindingBuilderlevelIn both of them the core remains the same :
WorkflowFinding.locationto extract the start and end rows related to the impacted snippetHappy to iterate on this idea. If one of them makes sense, happy to add a commit with proper docs
How to test