Conversation
woodruffw
commented
Jul 20, 2026
Comment on lines
+43
to
+44
| // TODO: `from_str_with_validation` here. | ||
| let inner = yaml_serde::from_str(&contents)?; |
Member
Author
There was a problem hiding this comment.
This would be easy enough to stub-in with SchemaStore like we do for other inputs.
https://www.schemastore.org/pre-commit-config.json
That'll be a follow-up PR.
woodruffw
commented
Jul 20, 2026
| impl PreCommitHooks { | ||
| pub(crate) fn from_string(contents: String, key: InputKey) -> Result<Self, CollectionError> { | ||
| // TODO: `from_str_with_validation` here. | ||
| let inner = yaml_serde::from_str(&contents)?; |
Member
Author
There was a problem hiding this comment.
Same as above:
woodruffw
marked this pull request as ready for review
July 22, 2026 11:19
4 tasks
jylenhof
pushed a commit
to jylenhof/gh-action-pulse
that referenced
this pull request
Aug 4, 2026
Automated mise tool upgrades from local config. Updated tools: - `zizmor` Command: `mise upgrade --bump --local zizmor` <details> <summary>Version changelog (zizmor)</summary> | Tool | Requested | Installed | |------|-----------|-----------| | `zizmor` | `1.28.0` → `1.29.0` | `1.28.0` → `1.29.0` | </details> <details> <summary>Release notes (1 tools)</summary> <details> <summary>zizmor: `1.28.0` → `1.29.0` (zizmorcore/zizmor)</summary> ### v1.29.0 ## New Features 🌈[🔗](https://docs.zizmor.sh/release-notes/#new-features) - zizmor now has **experimental** support for auditing pre-commit inputs, meaning both pre-commit configuration and hook definitions ([#2209](zizmorcore/zizmor#2209)) - New audit: [insecure-url-scheme](https://docs.zizmor.sh/audits/#insecure-url-scheme) detects usages of insecure (i.e. plaintext) protocols when making network requests. The initial version of this audit is limited to pre-commit inputs only ([#2228](zizmorcore/zizmor#2228)) - zizmor now supports GitHub's "self-repository" reference syntax for local actions, e.g. `uses: $/foo/bar` instead of a manual checkout and `uses: ./foo/bar` ([#2248](zizmorcore/zizmor#2248)) ## Changes⚠️ [🔗](https://docs.zizmor.sh/release-notes/#changes) - The [unpinned-uses](https://docs.zizmor.sh/audits/#unpinned-uses) and [unpinned-images](https://docs.zizmor.sh/audits/#unpinned-images) audits have been separated more cleanly: [unpinned-uses](https://docs.zizmor.sh/audits/#unpinned-uses) is now principally responsible for Git-style `uses:` clauses, whereas [unpinned-images](https://docs.zizmor.sh/audits/#unpinned-images) is now responsible for `docker://`-style `uses:` clauses (in addition to already checking other image references) ([#2222](zizmorcore/zizmor#2222)) ## Removals 🌅[🔗](https://docs.zizmor.sh/release-notes/#removals) - `--collect=workflows-only` and `--collect=actions-only` have been fully removed. Use `--collect=workflows` and `--collect=actions` for the replacement behavior ([#2242](zizmorcore/zizmor#2242)) ## Bug Fixes 🐛[🔗](https://docs.zizmor.sh/release-notes/#bug-fixes) - Fixed a bug where zizmor would reject a valid workflow definition for containing a literal jobs.<job>.outputs.<name> value for being a non-string ([#2220](https://github.com/zizmorcore/zizmor/iss… (truncated) </details> </details> Modified files: - `.mise.toml`
jylenhof
pushed a commit
to jylenhof/gh-action-pulse
that referenced
this pull request
Aug 4, 2026
Automated mise tool upgrades from local config. Updated tools: - `zizmor` Command: `mise upgrade --bump --local zizmor` <details> <summary>Version changelog (zizmor)</summary> | Tool | Requested | Installed | |------|-----------|-----------| | `zizmor` | `1.28.0` → `1.29.0` | `1.28.0` → `1.29.0` | </details> <details> <summary>Release notes (1 tools)</summary> <details> <summary>zizmor: `1.28.0` → `1.29.0` (zizmorcore/zizmor)</summary> ### v1.29.0 ## New Features 🌈[🔗](https://docs.zizmor.sh/release-notes/#new-features) - zizmor now has **experimental** support for auditing pre-commit inputs, meaning both pre-commit configuration and hook definitions ([#2209](zizmorcore/zizmor#2209)) - New audit: [insecure-url-scheme](https://docs.zizmor.sh/audits/#insecure-url-scheme) detects usages of insecure (i.e. plaintext) protocols when making network requests. The initial version of this audit is limited to pre-commit inputs only ([#2228](zizmorcore/zizmor#2228)) - zizmor now supports GitHub's "self-repository" reference syntax for local actions, e.g. `uses: $/foo/bar` instead of a manual checkout and `uses: ./foo/bar` ([#2248](zizmorcore/zizmor#2248)) ## Changes⚠️ [🔗](https://docs.zizmor.sh/release-notes/#changes) - The [unpinned-uses](https://docs.zizmor.sh/audits/#unpinned-uses) and [unpinned-images](https://docs.zizmor.sh/audits/#unpinned-images) audits have been separated more cleanly: [unpinned-uses](https://docs.zizmor.sh/audits/#unpinned-uses) is now principally responsible for Git-style `uses:` clauses, whereas [unpinned-images](https://docs.zizmor.sh/audits/#unpinned-images) is now responsible for `docker://`-style `uses:` clauses (in addition to already checking other image references) ([#2222](zizmorcore/zizmor#2222)) ## Removals 🌅[🔗](https://docs.zizmor.sh/release-notes/#removals) - `--collect=workflows-only` and `--collect=actions-only` have been fully removed. Use `--collect=workflows` and `--collect=actions` for the replacement behavior ([#2242](zizmorcore/zizmor#2242)) ## Bug Fixes 🐛[🔗](https://docs.zizmor.sh/release-notes/#bug-fixes) - Fixed a bug where zizmor would reject a valid workflow definition for containing a literal jobs.<job>.outputs.<name> value for being a non-string ([#2220](https://github.com/zizmorcore/zizmor/iss… (truncated) </details> </details> Modified files: - `.mise.toml`
jylenhof
pushed a commit
to jylenhof/gh-action-pulse
that referenced
this pull request
Aug 4, 2026
Automated mise tool upgrades from local config. Updated tools: - `zizmor` Command: `mise upgrade --bump --local zizmor` <details> <summary>Version changelog (zizmor)</summary> | Tool | Requested | Installed | |------|-----------|-----------| | `zizmor` | `1.28.0` → `1.29.0` | `1.28.0` → `1.29.0` | </details> <details> <summary>Release notes (1 tools)</summary> <details> <summary>zizmor: `1.28.0` → `1.29.0` (zizmorcore/zizmor)</summary> ### v1.29.0 ## New Features 🌈[🔗](https://docs.zizmor.sh/release-notes/#new-features) - zizmor now has **experimental** support for auditing pre-commit inputs, meaning both pre-commit configuration and hook definitions ([#2209](zizmorcore/zizmor#2209)) - New audit: [insecure-url-scheme](https://docs.zizmor.sh/audits/#insecure-url-scheme) detects usages of insecure (i.e. plaintext) protocols when making network requests. The initial version of this audit is limited to pre-commit inputs only ([#2228](zizmorcore/zizmor#2228)) - zizmor now supports GitHub's "self-repository" reference syntax for local actions, e.g. `uses: $/foo/bar` instead of a manual checkout and `uses: ./foo/bar` ([#2248](zizmorcore/zizmor#2248)) ## Changes⚠️ [🔗](https://docs.zizmor.sh/release-notes/#changes) - The [unpinned-uses](https://docs.zizmor.sh/audits/#unpinned-uses) and [unpinned-images](https://docs.zizmor.sh/audits/#unpinned-images) audits have been separated more cleanly: [unpinned-uses](https://docs.zizmor.sh/audits/#unpinned-uses) is now principally responsible for Git-style `uses:` clauses, whereas [unpinned-images](https://docs.zizmor.sh/audits/#unpinned-images) is now responsible for `docker://`-style `uses:` clauses (in addition to already checking other image references) ([#2222](zizmorcore/zizmor#2222)) ## Removals 🌅[🔗](https://docs.zizmor.sh/release-notes/#removals) - `--collect=workflows-only` and `--collect=actions-only` have been fully removed. Use `--collect=workflows` and `--collect=actions` for the replacement behavior ([#2242](zizmorcore/zizmor#2242)) ## Bug Fixes 🐛[🔗](https://docs.zizmor.sh/release-notes/#bug-fixes) - Fixed a bug where zizmor would reject a valid workflow definition for containing a literal jobs.<job>.outputs.<name> value for being a non-string ([#2220](https://github.com/zizmorcore/zizmor/iss… (truncated) </details> </details> Modified files: - `.mise.toml` Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1799 for context.
This does not add any audits yet; this is just to ensure we can model and inject pre-commit inputs into zizmor's machinery.