Make config discovery root-aware - #2234
Merged
Merged
Conversation
4 tasks
woodruffw
commented
Jul 26, 2026
woodruffw
marked this pull request as ready for review
July 27, 2026 02:51
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP.Fixes #2229.TL;DR: This takes the repository root that we discover for path presentation (see #2095) and uses it as another hint during config discovery. This is a lot more reliable than our previous heuristics, which involved trying to figure out where we were in some directory tree.
(Like with path presentation, the previous heuristics remain for when we don't have a Git repo to root against. This can happen e.g. if the user runs
zizmor .on an extracted archive rather than a real repository.)Needs more tests, plus another tweak to the heuristics to ensure we treat.github/workflowscorrectly.Another perk of this is that it adds a proper "workspace" testing abstraction, which will make it possible for me to patch the downstream testing pain experienced in #2139.