fix: template-injection: consider runner.tool_cache safe - #297
Merged
Conversation
Signed-off-by: William Woodruff <william@yossarian.net>
|
Is this still working as intended? When I run zizmor with Without Either |
Member
Author
Yes, please see the persona docs: https://docs.zizmor.sh/usage/#using-personas Specifically, the pedantic persona means "include code smells, even if not likely exploitable." zizmor considers all template expansions to be code smells, and puts likely non-exploitable ones under the pedantic persona so that they don't show up by default. More information on that is documented under the audit as well: https://docs.zizmor.sh/audits/#template-injection (See the first tip callout in that section for context) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds another always-safe context to the safe list.