Skip to content

feat: Fix Sarif schema and add rules to Sarif files #330

Merged
woodruffw merged 3 commits into
zizmorcore:mainfrom
fcasal:add_rules_sarif
Dec 19, 2024
Merged

feat: Fix Sarif schema and add rules to Sarif files #330
woodruffw merged 3 commits into
zizmorcore:mainfrom
fcasal:add_rules_sarif

Conversation

@fcasal

@fcasal fcasal commented Dec 19, 2024

Copy link
Copy Markdown
Contributor

This PR

  • fixes the schema used in the sarif files
  • adds a rules section with the documentation URL
  • replaces the finding identifier with the finding description in the result's message

When viewed with the Sarif Explorer VSCode extension,
Before
image

After
image

woodruffw
woodruffw approved these changes Dec 19, 2024
View reviewed changes

@woodruffw woodruffw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fcasal!

@woodruffw woodruffw added the enhancement New feature or request label Dec 19, 2024
@woodruffw woodruffw changed the title Fix Sarif schema and add rules to Sarif files feat: Fix Sarif schema and add rules to Sarif files Dec 19, 2024
@woodruffw woodruffw enabled auto-merge (squash) December 19, 2024 12:48
@woodruffw woodruffw merged commit f5a22cf into zizmorcore:main Dec 19, 2024
@BrewTestBot BrewTestBot mentioned this pull request Dec 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@woodruffw woodruffw woodruffw approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fcasal @woodruffw