Skip to content

fix: handle context accesses following calls#340

Merged
woodruffw merged 10 commits into
mainfrom
ww/bug-339
Dec 21, 2024
Merged

fix: handle context accesses following calls#340
woodruffw merged 10 commits into
mainfrom
ww/bug-339

Conversation

@woodruffw

@woodruffw woodruffw commented Dec 20, 2024

Copy link
Copy Markdown
Member

WIP; These grammar changes mean the syntax tree itself is different, so I need to update the walk as well.

Fixes #339.

Signed-off-by: William Woodruff <william@yossarian.net>
@woodruffw woodruffw added the bugfix Fixes a known bug label Dec 20, 2024
@woodruffw woodruffw self-assigned this Dec 20, 2024
@woodruffw

Copy link
Copy Markdown
Member Author

Some notes for myself:

  • The Context node is now insufficiently expressive: an expression like fromJson(steps.runs.outputs.data).workflow_runs[0].id should be:
Context
  Call { fromJson args: Context { lit:steps, lit:runs, lit:outputs, lit:data } }
  lit:workflow_runs
  Index { 0 }
  lit:id

Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
@woodruffw
woodruffw marked this pull request as ready for review December 21, 2024 01:41
@woodruffw
woodruffw merged commit 7a87adb into main Dec 21, 2024
@woodruffw
woodruffw deleted the ww/bug-339 branch December 21, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Fixes a known bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: couldn't parse expression: fromJson(...)

1 participant