Skip to content

feat: adds support to non-configurable caching on cache-audit - #345

Merged
woodruffw merged 2 commits into
zizmorcore:mainfrom
tewokumu:ufs/patch-15
Dec 23, 2024
Merged

woodruffw merged 2 commits into
zizmorcore:mainfrom
tewokumu:ufs/patch-15

Conversation

@ubiratansoares

Copy link
Copy Markdown
Contributor

Another follow-up for #334

Here we tweak a bit the models for CacheAwareAction, moving into to an enum an introducing Configurable and NotConfigurable variants.

The not-configurable variant covers Actions like Mozilla-Actions/sccache-action, which always cache/restore and does not provide control inputs / control values to disable caching.

I added a snapshot test convering this new use case. Added some docs on the semantics of CacheControlInput:OptIn and CacheControlInput:OptOut as well.

ubiratansoares and others added 2 commits December 22, 2024 22:56
Signed-off-by: William Woodruff <william@yossarian.net>

@woodruffw woodruffw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ubiratansoares!

@woodruffw
woodruffw enabled auto-merge (squash) December 23, 2024 00:01
@woodruffw
woodruffw merged commit 6e4c340 into zizmorcore:main Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants