Skip to content

Add forbidden-uses audit#574

Closed
Holzhaus wants to merge 19 commits into
zizmorcore:mainfrom
Holzhaus:forbidden-uses
Closed

Add forbidden-uses audit#574
Holzhaus wants to merge 19 commits into
zizmorcore:mainfrom
Holzhaus:forbidden-uses

Conversation

@Holzhaus

Copy link
Copy Markdown
Contributor

Fixes #558.

Not finished yet, but if you have any comments on the configuration part, let me know.

Comment thread src/audit/mod.rs Outdated
Comment thread src/config.rs Outdated
Comment thread src/audit/forbidden_uses.rs Outdated
@woodruffw

Copy link
Copy Markdown
Member

Thanks @Holzhaus! This looks great as a start; I left some initial comments.

@woodruffw woodruffw added new-audit New audits enhancement New feature or request labels Feb 26, 2025
@woodruffw

Copy link
Copy Markdown
Member

Just flagging as a note for myself: when documenting this new audit, we'll need to make sure users understand what it can and can't do. In particular, if a user is concerned about impostor commits, then this audit doesn't protect against those directly since foo/bar@hash... can be a hash... from a different org/repo in foo/bar's network.

This is OK IMO, since we have the impostor-commit audit for exactly this purpose. But it should be clear in the docs to users that they need to run both, if impostor commits are inside their threat model.

@woodruffw

Copy link
Copy Markdown
Member

I thought about this some more, and I think I want to merge this with the existing unpinned-uses audit -- the two overlap closely, and would conflict in some ways if left unmerged.

woodruffw added a commit that referenced this pull request Apr 13, 2025
Co-authored-by: Jan Holthuis <jan.holthuis@ruhr-uni-bochum.de>
@woodruffw woodruffw mentioned this pull request Apr 13, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request new-audit New audits

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Manual allowlist/denylist for actions (forbidden-uses)

2 participants