feat: respect .gitignore files when collecting inputs - #575
Merged
Conversation
Member
Author
|
This works well for me locally, but I'm realizing that I don't have a great regression testcase for ensuring this doesn't accidentally break things. So I'm going to work on that first before merging here. |
Audit inputs shouldn't be sorted by inclusion order, but by key. Switching to `ignore` for directory walks revealed that we were accidentally depending on the inclusion order, which was not consistent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses the excellent
ignorecrate to honor.gitignorewhile collecting inputs.For the moment, we only honor
.gitignoreand its family of files (including the global.gitignoreand.git/info/exclude). We don't honor.ignoreor similar files, although we could in the future.Additionally, in the future we could easily honor our own
.zizmorignoreor similar file, although I don't love the idea of a separate config file for this. Instead, that could perhaps go inzizmor.ymland be configured viaignore's support for overrides.Closes #556.