bugfix: sarif: add working directory to invocation - #621
Merged
Conversation
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
This reverts commit 4d3f297.
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
This reverts commit 40c6224.
Signed-off-by: William Woodruff <william@yossarian.net>
This reverts commit c5ee083.
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Contributor
Contributor
Signed-off-by: William Woodruff <william@yossarian.net>
Contributor
Signed-off-by: William Woodruff <william@yossarian.net>
Contributor
See #622. Signed-off-by: William Woodruff <william@yossarian.net>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #604.
This performs the fix by partially reverting #572 -- the "presentation" path is still used in formats like the "plain" (cargo-style) output, but the SARIF format now uses a
sarif_pathhelper that removes the input prefix (even when that input prefix is something relative that GitHub should be handling correctly).To test this, I've added a new
test-sarifworkflow that gets triggered by thetest-sarif-presentationlabel -- when a PR is labeled as such, the workflow runs and uses a custom category to test any SARIF changes made.I don't have a good way to test this yet -- my initial thought was to add some kind ofissue_commenttrigger so that I could do something like/sariftest, but I don't really like that. Another option would be apull_requestwith thelabeledsub-event. Either way, the goal would be to run a separate workflow (or job) that performs the SARIF steps for testing purposes.