Skip to content

feat: rewrite unpinned-uses, fold in forbidden-uses - #663

Merged
woodruffw merged 30 commits into
mainfrom
refactor-unpinned-uses
Apr 13, 2025
Merged

feat: rewrite unpinned-uses, fold in forbidden-uses#663
woodruffw merged 30 commits into
mainfrom
refactor-unpinned-uses

Conversation

@woodruffw

@woodruffw woodruffw commented Apr 13, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

This rewrites unpinned-uses on top of the core idea of #574.

TODOs:

  • Snapshot tests, including config files
  • Documentation

Closes #574. See #558.

Holzhaus and others added 22 commits March 1, 2025 20:11
@Holzhaus
feat(config): Add a way to add audit-specific configuration
d064378
@Holzhaus
feat(audit): Add forbidden-uses audit
9cd879d
@Holzhaus
refactor(config): Make rule_config return a result
62e768a
@Holzhaus
chore(audit): Move default allowlist to const array
20b7fa4
@Holzhaus
refactor(audit): Include Config in AuditState and pass by reference
f5e673a
@Holzhaus
chore(config): Add support for specifying policy but not ignore
80444c4
@Holzhaus
chore(audit): Use auditor persona for forbidden_uses w/o config
9f6411d
@Holzhaus
Merge branch 'main' of github.com:woodruffw/zizmor into forbidden-uses
cbf37a7
@Holzhaus
chore(finding): Add Deserialize implementations
b374af6
@Holzhaus
chore(audit): Reduce log noise for forbidden_uses audit
fabc1b3
@Holzhaus
chore(audit): Treat * as wildcard in forbidden-uses audit
3c2e00e
@woodruffw
Merge branch 'main' into forbidden-uses
cc5c9b0
@woodruffw
simplify config a bit
b767031 
Percolate the None state through, rather than requiring a default
throughout.
@woodruffw
rename fields, remove a helper
792a563
@woodruffw
Merge branch 'main' into forbidden-uses
fa0bd82
@woodruffw
lint, fmt
4113d0d
@woodruffw
type, add github/* to allowlist by default
2527b9a
@woodruffw
forbidden_uses: add dependabot/* to default allowlist
8528294 
Another first-party GH org.

Signed-off-by: William Woodruff <william@yossarian.net>
@woodruffw
Merge branch 'main' into forbidden-uses
31f81e2
@woodruffw
[WIP] refactor unpinned-uses based on forbidden-uses
897ebf3 
Signed-off-by: William Woodruff <william@yossarian.net>
@woodruffw
fill in new impl
7dc3fbb
@woodruffw
rm test.yml
332b9b3
@woodruffw woodruffw self-assigned this Apr 13, 2025
@woodruffw
woodruffw marked this pull request as ready for review April 13, 2025 19:52
@woodruffw

woodruffw commented Apr 13, 2025

Copy link
Copy Markdown
Member Author

This is good to go functionally, although I just realized it's missing a decent chunk of #558: it allows for various pinning policies, but doesn't provide a basic denylist capability.

Given that, I suppose zizmor does need some variant of a dedicated forbidden-uses audit. I'm going to merge here since this adds a lot of the needed scaffolding, then rebuild on top of #574.

@woodruffw woodruffw added the enhancement New feature or request label Apr 13, 2025
@woodruffw
woodruffw merged commit 8329726 into main Apr 13, 2025
@woodruffw
woodruffw deleted the refactor-unpinned-uses branch April 13, 2025 20:00
This was referenced Apr 15, 2025
Closed
Closed
aldur pushed a commit to aldur/zizmor that referenced this pull request May 5, 2025
@woodruffw @Holzhaus @aldur
feat: rewrite unpinned-uses, fold in forbidden-uses (zizmorcore#663)
4d739b5 
Co-authored-by: Jan Holthuis <jan.holthuis@ruhr-uni-bochum.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@woodruffw woodruffw

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@woodruffw @Holzhaus