refactor: begin splitting out syntax/sema error handling - #734
Merged
Conversation
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Special-case for empty inputs. Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Member
Author
|
The machinery of this is done, I just need to think more about how I want to do the skipping such that the current mess of collection code become DRYer. |
Signed-off-by: William Woodruff <william@yossarian.net>
This needs more thought. Signed-off-by: William Woodruff <william@yossarian.net>
woodruffw
marked this pull request as ready for review
May 3, 2025 00:27
For now, to get around the breakage being fixed in this very PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP.Starting with the workflow path; I need to handle the action path as well.TODO:
anyhow::Errors here (these are causing pain when nested/chained)Closes #732.
Fixes #725.