Repository navigation
Extract context patterns from webhook schemata - #745
Conversation
Signed-off-by: William Woodruff <william@yossarian.net>
Not sure about this; will probably remove.
|
Noting for myself: doing a linear scan over thousands of fixed contexts for each dynamic context (i.e. parsed from expressions) is going to get slow, quick. This is probably going to require a prefix tree/trie structure so that I can do efficient prefix lookups. Edit: Candidate: https://docs.rs/trie-rs/latest/trie_rs/#modules OTOH a much simpler approach here is a regex/DFA transformation. Related for me to look at: DAFSAs, DAWGs, etc. https://en.wikipedia.org/wiki/Deterministic_acyclic_finite_state_automaton |
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Broken out of #745. Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
|
Preliminary benchmarking shows a mixed effect on performance: running with (This is primarily a correctness change so even a small performance hit would be worth it, but it's good to see that it actually makes things faster in some cases.) |
This essentially double-parses every expression for a check that's almost but not quite equivalent to the dataflow contexts collection. Removing it gives us a small performance boost and makes the intent clearer. Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
WIP. Still thinking through how I want to approach this.Fixes #674.
Signed-off-by: William Woodruff william@yossarian.net