feat: add CodeQL injection sink data - #849
Merged
Merged
Conversation
woodruffw
force-pushed
the
ww/codeql-injection-sinks
branch
from
May 23, 2025 21:11
8994407 to
64723ce
Compare
Co-authored-by: Marcono1234 <Marcono1234@users.noreply.github.com> Signed-off-by: William Woodruff <william@yossarian.net>
woodruffw
force-pushed
the
ww/codeql-injection-sinks
branch
from
May 23, 2025 21:15
64723ce to
af2236f
Compare
woodruffw
marked this pull request as ready for review
May 23, 2025 21:35
Marcono1234
reviewed
May 24, 2025
Contributor
There was a problem hiding this comment.
Thanks a lot for taking this over! And sorry that I had not updated my PR yet. I had started making some modifications locally (nothing big), but did not get around to finishing it.
I have added some comments here, hopefully they are useful, but feel free to consider them at most suggestions.
Co-authored-by: Marcono1234 <Marcono1234@users.noreply.github.com>
Also remove a duplicated path construction. Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #743.
Closes #417.
TODOs: