Skip to content

Exclude github.run_* from template injection check - #92

Merged
woodruffw merged 1 commit into
zizmorcore:mainfrom
funnelfiasco:issue91-exclude_github.run
Oct 31, 2024
Merged

Exclude github.run_* from template injection check#92
woodruffw merged 1 commit into
zizmorcore:mainfrom
funnelfiasco:issue91-exclude_github.run

Conversation

@funnelfiasco

Copy link
Copy Markdown
Contributor

These are unique numbers assigned by GitHub and can't be used to inject shell commands.

Fixes #91

These are unique numbers assigned by GitHub and can't be used to inject
shell commands.

Fixes zizmorcore#91

Signed-off-by: Ben Cotton <ben@kusari.dev>
@woodruffw

Copy link
Copy Markdown
Member

Thanks @funnelfiasco! Agreed, these are harmless to expand.

@woodruffw woodruffw added false-positive enhancement New feature or request bugfix Fixes a known bug and removed enhancement New feature or request labels Oct 31, 2024
@woodruffw
woodruffw merged commit 97d0d67 into zizmorcore:main Oct 31, 2024
@funnelfiasco
funnelfiasco deleted the issue91-exclude_github.run branch October 31, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Fixes a known bug false-positive

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Exclude github.run_* from template injection test

2 participants