Skip to content

Add Fix for cache-poisoning audit rule - #923

Merged
woodruffw merged 13 commits into
zizmorcore:mainfrom
mostafa:cache-poisoning-fix
Jul 9, 2025
Merged

woodruffw merged 13 commits into
zizmorcore:mainfrom
mostafa:cache-poisoning-fix

Conversation

@mostafa

@mostafa mostafa commented Jun 8, 2025

Copy link
Copy Markdown
Contributor

The Fixes generated by this audit suggest how to disable caching in GitHub Actions workflows when publishing artifacts. They use the MergeInto operation to update the relevant action's with block, setting the cache-related field (e.g., enable-cache) to a value (such as 'false' or true) that disables caching according to the action's configuration. For non-configurable actions, the Fix suggests manual removal or replacement.

xref #876

@funnelfiasco funnelfiasco added bugfix Fixes a known bug and removed bugfix Fixes a known bug labels Jun 10, 2025
@mostafa
mostafa force-pushed the cache-poisoning-fix branch from e2cfa4a to 30d29ad Compare June 11, 2025 13:02
@mostafa mostafa mentioned this pull request Jun 24, 2025
11 tasks
@mostafa
mostafa force-pushed the cache-poisoning-fix branch from 30d29ad to 29c847b Compare July 4, 2025 17:38
@mostafa
mostafa marked this pull request as draft July 4, 2025 18:20
@mostafa
mostafa marked this pull request as ready for review July 4, 2025 18:44
@mostafa

mostafa commented Jul 4, 2025

Copy link
Copy Markdown
Contributor Author

@woodruffw I fixed the issues and reverted most of the changes to coordinate.rs and I think it is ready. Feel free to change it however you see fit, especially for dispositions.

@woodruffw

Copy link
Copy Markdown
Member

Thanks @mostafa! I'll be able to review this after the weekend.

@woodruffw woodruffw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, meant to press "submit" on these yesterday 😅

Comment thread crates/zizmor/src/audit/cache_poisoning.rs Outdated
Comment thread crates/zizmor/src/audit/cache_poisoning.rs Outdated
Comment thread crates/zizmor/src/audit/cache_poisoning.rs Outdated
@mostafa
mostafa requested a review from woodruffw July 8, 2025 18:51
@mostafa

mostafa commented Jul 8, 2025

Copy link
Copy Markdown
Contributor Author

@woodruffw Thanks for the review! I fixed the issues.

@woodruffw

Copy link
Copy Markdown
Member

Thanks @mostafa, I'll do another review tonight!

@woodruffw woodruffw added enhancement New feature or request autofix Auto-fix functionality labels Jul 9, 2025

@woodruffw woodruffw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a ton @mostafa!

@woodruffw
woodruffw merged commit c3706e2 into zizmorcore:main Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autofix Auto-fix functionality enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants