Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact icons are not centered in the footer #171

Closed
filippofontana opened this issue Mar 11, 2024 · 4 comments
Closed

Contact icons are not centered in the footer #171

filippofontana opened this issue Mar 11, 2024 · 4 comments
Milestone

Comments

@filippofontana
Copy link
Contributor

filippofontana commented Mar 11, 2024

The contact icons in the footer are declared as a list of links and, due to <li> css rules, they have a margin left of 20px which makes them not aligned with the rest of the footer's content. This is more visible when you have, for instance, three contact icons.

Example:

list

I have prepared a new commit with the contact icons displayed without the <li> tag and using flex for displaying and aligning stuff (with some padding to emulate the previous style). If this sounds ok, I can submit a pull request.

Example of the updated design:

flex

Let me know what you think!

UPDATE: of course I can replicate exactly the padding between the icons and the other stuff under them and also between the icons themselves.

@zjedi
Copy link
Owner

zjedi commented Mar 11, 2024

looks good!
Not sure why it was a list, it could have something to do with accessibility ... or maybe not. I am not sure, maybe @nai888 would know?

@nai888
Copy link
Contributor

nai888 commented Mar 11, 2024

@zjedi Nope, feel free to change it!

@filippofontana
Copy link
Contributor Author

Ok, thanks for the feedback guys! I'll send a PR soon.

@filippofontana
Copy link
Contributor Author

Solved with #172.

@zjedi zjedi added this to the v2.0 milestone Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants