Don't check connection state in Locker#assert! #78

Merged
merged 1 commit into from Mar 3, 2014

Projects

None yet

2 participants

@eric
zk-ruby member

Rely on the call to zk.exists? to check that.

I've noticed that the threaded connection has a :retry_duration which would allow for temporary disconnections to be recovered from, but this check to zk.connected? prevents that from working.

This way, we can let the call to zk.exists? do the job of checking if we're connected, and it will place nice with reconnection.

@eric eric Don't check connection state in Locker#assert!
Rely on the call to zk.exists? to check that
d4bcfa6
@slyphon

seems plausible.

@eric eric merged commit 34fb905 into master Mar 3, 2014

1 check passed

Details default The Travis CI build passed
@eric eric deleted the dont-check-connection-state-in-lock-assert branch Mar 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment