Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

changelog entry, bump version to 1.2.3, additional paranoid case in s…

…hutdown
  • Loading branch information...
commit 980488c59e07b4a70f7fe3bac0dd532da01cc97d 1 parent fd04847
@slyphon slyphon authored
Showing with 11 additions and 2 deletions.
  1. +9 −0 CHANGELOG
  2. +1 −1  ext/c_zookeeper.rb
  3. +1 −1  lib/zookeeper/version.rb
View
9 CHANGELOG
@@ -1,3 +1,12 @@
+v1.2.3 ensure that all threads are woken up on shutdown
+
+ * There was an edge case where a call would be queued up and its thread
+ sleeping waiting for a response, but that response would never come because
+ the connection was shut down. This version includes a patch for that case
+ to ensure that if a call is in 'pending' state, and shutdown time arrives
+ that all pending threads will receive a Zookeeper::Exceptions::NotConnected
+ exception.
+
v1.2.2 avoid race while waiting for connection
* There was a possible race in CZookeeper#wait_until_connected where if we
View
2  ext/c_zookeeper.rb
@@ -256,7 +256,7 @@ def event_thread_body
if @_shutting_down and not (@_closed or is_unrecoverable)
logger.debug { "we're in shutting down state, there are #{@reg.in_flight.length} in_flight completions" }
- until @reg.in_flight.empty? or is_unrecoverable
+ until @reg.in_flight.empty? or is_unrecoverable or @_closed
zkrb_iterate_event_loop
iterate_event_delivery
logger.debug { "there are #{@reg.in_flight} in_flight completions left" }
View
2  lib/zookeeper/version.rb
@@ -1,4 +1,4 @@
module Zookeeper
- VERSION = '1.2.2'
+ VERSION = '1.2.3'
DRIVER_VERSION = '3.3.5'
end
Please sign in to comment.
Something went wrong with that request. Please try again.