-
Add Ruby's "libdir" to the library search path.
neilconway committedFeb 7, 2011 This is necessary if the default linker search path does not include the shared libraries for the version of Ruby being used.
-
neilconway committed
Feb 7, 2011
-
Use a pipe to notify Ruby thread of new ZK events.
neilconway committedFeb 6, 2011 Previous approach was to use polling with a period of 100 msec. The new approach is to associate a pipe with the queue that we use to send events from ZK to Ruby land. When the Ruby consumer runs out of events to process, it does rb_thread_select() on the pipe. Whenever the ZK side enqueues a new event, we write into the pipe.
-
neilconway committed
Feb 6, 2011
-
missing unlock in error path of zkrb_queue_free
jmhodges committedJan 31, 2011
-
neilconway committed
Jan 29, 2011 * Previous coding depending on recursive mutexes; since we can't easily guarantee those and use the static PTHREAD_MUTEX_INITIALIZER, just avoid the need for recursive mutexes for now. * Add a missing pthread_mutex_unlock() to an error return path. * Fix harmless compiler warning.
-
Merge branch 'master' of github.com:twitter/zookeeper
neilconway committedJan 29, 2011 Conflicts: ext/zookeeper_lib.c
-
Fix memory leak in zkrb_event_free().
neilconway committedJan 28, 2011 -
Fix memory leaks in #create() and #set_acl().
neilconway committedJan 28, 2011 -
Fix use-after-free() in zkrb_state_callback().
neilconway committedJan 28, 2011 -
neilconway committed
Jan 28, 2011 -
Fix memory leak in queue implementation.
neilconway committedJan 28, 2011 The current coding pre-allocates the queue node for the next to-be-inserted queue element. This seems a strange way to do things, but I'll leave things as they are for now.
-
Squelch more harmless compiler warnings.
neilconway committedJan 28, 2011 -
Fix memory leak in #get_acl().
neilconway committedJan 28, 2011 -
Tweak: correctly pre-size allocated Ruby arrays.
neilconway committedJan 28, 2011
-
Merge branch 'master' into session_segv
jmhodges committedJan 27, 2011 -
Merge branch 'master_neilconway'
jmhodges committedJan 27, 2011 -
remove misleading part of comment
jmhodges committedJan 27, 2011 -
Avoid incorrectly freeing a session context
jmhodges committedJan 27, 2011 The check ZKH_SETUP_EVENT was incorrect for the zkrb_state_callback. req_id can be different from the global request id and still be using the same callback function. Nasty work. Fixes #1.
-
try a little harder to remove gcc -O flags
jmhodges committedJan 27, 2011 -
Merge branch 'master' of github.com:neilconway/zookeeper
neilconway committedJan 27, 2011 -
Fix #get() for paths without associated data.
neilconway committedJan 27, 2011 ZK allows a path to be created that has no associated data. In the previous coding, doing a #get() on such a path would result in raising a Ruby exception: zoo_get() returns data_len == -1 for the path, which isn't a legal string length.
-
Fix memory leak; disallow ops on closed ZK handle.
neilconway committedJan 26, 2011 This patch fixes a per-connection memory leak: the previous coding allocated a zkrb_calling_context for each ZK handle but neglected to free it. This patch also raises a Ruby exception if any operations on performed on a closed ZK handle, until #reopen() is called. Such operations would just segfault anyway.
-
Avoid possible double free() of ZK handle.
neilconway committedJan 26, 2011 If #close() was invoked, zookeeper_close() might be invoked again by the Ruby GC, leading to a double free(). The previous coding also neglected to call zookeeper_close() on a non-connected ZK handle, which would leak resources.
-
Avoid spurious warning when running tests.
neilconway committedJan 26, 2011 -
Squelch more (harmless) compiler warnings.
neilconway committedJan 26, 2011 -
neilconway committed
Jan 26, 2011 -
Fix typo in zkrb_strings_stat_callback().
neilconway committedJan 26, 2011 Previously assigned to the wrong union member -- not super likely to cause a problem, but illegal per C99 strict aliasing.
-
Fix some innocuous compiler warnings.
neilconway committedJan 26, 2011
-
neilconway committed
Jan 25, 2011 Not clear that this is the right fix, but unbreaks the build for me.
-
Only free the calling_ctx after removing the data
jmhodges committedJan 22, 2011 Cleans up one possible SIGSEGV.
-
use static initializer for zkrb_q_mutex
jmhodges committedJan 21, 2011 -
check if q, q->tail or q->head is NULL in zkrb_enqueue
jmhodges committedJan 20, 2011