Join GitHub today
Proper CONTRIBUTING.md #1856
@yahiheb's recent pull requests have done a lot to clean up the codebase but if there is no specification on what is preferred it will eventually need to be done again in the future. A proper specification on the preferred coding style in the CONTRIBUTING.md would be really helpful for current and future developers of the project.
* Update WalletWasabi.Documentation/PasswordFinder.md Co-Authored-By: Max Hillebrand <30683012+MaxHillebrand@users.noreply.github.com> * Fallback if filedialog fails. * Remove leftover code * Fix hang on QR code generation * Remove output scheduler * Use c# 7 pattern matching to merge type check and cast * Moved predicate, removes redundant where call * Using method groups instead of lamdas Syntax is more succint and less compile-time overheard by not using lambdas * Replaced with method group * Removed redundant catch clause * Removed redundant tostring call * Edit HandshakeAsync method * Add OneDayConfirmationTarget (144) as const * Fix typos * Replace 'can not' by cannot for consistency * Replace doesn't by does not for consistency * Fix typos * Replace labelling by labeling * Replace didn't by did not * Replace wasn't by was not * Replace isn't by is not * Remove unnecessary checks in TrySetWalletStates() method * Replace aren't by are not & hasn't by has not * Edit variable & parameter name * Use nameof instead of hardcoded strings * Correct variable name * Correct property & field names * Correct method, parameter, variable names * [skip ci] Update the methodology of seeding * Correct method, parameter, variable names (MemPool to Mempool) * Implement reduceonions function to the packager * Make if more efficient * Improve TestServicesAsync * Dump client version * Fix PinPadView Initialization * Ensure Filter Height integrity * Downgrade ClientVersion * fix expander * hide expander click area. * fix expander click area so its invisible. * fix crashing when starting with Lurking Wife Mode enabled. * unsubscribe isexpanded after first time. * use take(1) instead of firstasync * Remove duplicae null check, simplified state check * Removed unnecessary ternery expression * validate dust threshold is positive * validate port is not a reserved port * Reduced code by using object initializer * Update WalletWasabi.Documentation/PasswordFinder.md Co-Authored-By: nopara73 <firstname.lastname@example.org> * Removed unnecessary ternary expression * Use is instead of == * Correct members' names * Replace couldn't by could not * grammatical error fix * remove old check to see if qr is not already generated. * Use firstfilter * CodeFactor * Fix Send/Address box behavior according to AutoCopy setting * Improve text * Fix TotalAmount calculation when tx sent * Make code more efficient * Correct members' names * Remove S_ prefix for const (name violation rule) * Correct variable names * temporary preview of 0.8.1 rc. * update to avalonstudio.shell 0.8.1 and avalonia 0.8.1 * Correct variable names * Correct variable names * Order onions with Packager * Update the onion seed list * Dump Client Version * Update website links * Update versions in guides * Add detbuildguide to versionupdate notes * fix build error * Rename filenames * Boolean-String converter impl in SettingsView * Replace MaxClearConverter by BooleanStringConverter * Replace ShowHideSensitiveConverter by Bool2Str * fix up code * LurkingWifeMode on transaction view page * Fix message * Added mode attribute * Display sensitive data in red color * Fix typos * Replace don't by do not * Prefer expression body for properties * Remove unused member * Correct typos * Use DeepEquals for config file change detection * Update 20190617ContributionGame.md * [Refactor] Remove unused code * Change color to IndianRed * Remove useless CcjRoundConfig constructor * Update FAQ.md Two minor phrasing amendments, as discussed here: zkSNACKs#1717 (comment) * Simplify member access * Update and normalize Coding Conventons with uncontroversial guidelines (for pull request reviewing.) * Update CONTRIBUTING.md Closes zkSNACKs#1856 * Delete CodingConventions.md * Remove some unnecessary checks * CodeMaid * btcsessions * Cleanup code according to CodeMaid * New line before open brace (Remove Java-like brackets) * Edit new-line-before-open-brace entry in editorconfig (to override CodeMaid configuration) * Correct typos, capitalization, punctuation * Update CONTRIBUTING.md * Update CONTRIBUTING.md * Update CONTRIBUTING.md * Update CONTRIBUTING.md * Amount color changes to Red when no coins are selected * ordinialignorecase * Rename TotalAmount to SelectedAmount * Make SelectedAmount Money * syntax * Rename BtcFee to EstimatedBtcFee * Rename Amount to AmountText * Use UsdExchangeRate as ToProperty * Amount color changes to red when no coins are selected * Replace typewriter apostrophe by typographic apostrophe in PrivacyPolicy document * bugfix: add missing null check * Update project description and tags to match GitHub * Confirmations on confirmed checkmark tooltip * Remove fee slider when unavailable * Remove unnecessary checks * Use method group instead of lambda * Update CONTRIBUTING.md * Prefer Oaph Over Properties * Correct typo * Fix typos (occured & occurence) * Correct possible mistakes * Used Constants.SevenDaysConfirmationTar instead of 1008 * Small changes * Small typo corrections * Prefer expression body for operators * Small correction * Fix linux dock issue * Update CONTRIBUTING.md