Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Resolution Of The Contribution Game #2016

Closed
nopara73 opened this issue Jul 25, 2019 · 15 comments

Comments

@nopara73
Copy link
Collaborator

commented Jul 25, 2019

One month ago we announced a "Contribution Game" where we decided to pay out 1BTC for contributors in proportion to the number of changed lines. This game ends today.

Please send Bitcoin addresses to adam.ficsor73@gmail.com or on TumbleBit Slack to pay out the rewards!

Results

Wasabika Lines Reward(BTC)
@yahiheb 2575 0,26571045 btc
@danwalmsley 1743 0,1798675 btc
@jmacato 1338 0,13806625 btc
@molnard 1094 0,11288825 btc
@NicolasDorier 985 0,1016407 btc
@benthecarman 591 0,06098442 btc
@varsnotwars 548 0,05654731 btc
@lontivero 490 0,05056238 btc
@MaxHillebrand 192 0,0198122 btc
@raindogdance 98 0,01011248 btc
@Mixelated 14 0,00144464 btc
@Zolgarr 12 0,00123826 btc
@ravishwetha 6 0,00061913 btc
@xavierfiechter 3 0,00030957 btc
@morrisonbrett 2 0,00020638 btc

Special Awards ($100)

  • @yahiheb and @benthecarman both get an additional bonus of for catching two off by one errors those may have resulted in strange malfunctions here and there: #1890, #1994
  • @MaxHillebrand special award: 160 topic commented since June 25, 70 topic reviewed, creating Wasabi doc.

Notes

The contribution game resulted in a terrific GitHub activity growth, we probably were the most active Bitcoin project this month, after Bitcoin Core of course. However such growth did not come without hiccups.

  • I had to disqualify myself the very next day, because I realized I do way too many stylistic changes into the contributions of others before merging, which would had been unfair to make it count.
  • There were so many pull requests that we were not able to review them all in the available timeframe. Although we used this opportunity to democratize the merge access to the repo. Previously I was the only one who was able to merge, now @molnard and @lontivero also have merge access with the condition that a PR needs at least 2 approved review.
  • The game also encouraged numerous stylistic changes, which do not have a clear benefit. In response to this we had to introduce new contribution guidelines to be able to resolve some disputes systemically.
  • We encountered numerous GitHub statistics issues, which added up in the end and we were forced to painfully manually count the line additions and deletions to make up for the skewed statistics.

Calculations

@nopara73 nopara73 added the priority label Jul 25, 2019

@MaxHillebrand

This comment has been minimized.

Copy link
Collaborator

commented Jul 25, 2019

Thanks to @zkSNACKs for sponsoring this months contribution game, and especially thanks to all the 17 [!!!!!] contributors!

These were a couple intense blocks - and I'm proud to look back on what we have achieved! No question - Great Success.

I'm looking forward to continuing the collaboration with y'all.


Improvements

I think that the counting of lines does not serve as a decent algorithm to compare the contributions, and it seems to be rather a lot of manual review to calculate a somewhat balanced result. Since this bounty is a gracious gift by zkSnacks, I'd say that there is nothing wrong with having a more loose distribution rule. For example, I think that the special awards are a good example for how this can be done better: very view lines in the bug fixes - but very big impact - and an adequate compensation.

Why not distribute the entire bounty according to this "gut feeling"?

@nopara73

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 25, 2019

Yes @MaxHillebrand, the algo has to be improved for the next time we do this. But gut feeling is out of question. It must be something objective.

@benthecarman

This comment has been minimized.

Copy link
Collaborator

commented Jul 25, 2019

Thanks for doing this! I was initially turned off to working on Wasabi because I have hardly any C# experience but after this past month I've learned so much and will definitely continue to work on the project.

@yahiheb

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2019

@nopara73 @lontivero @molnard Thank you a lot guys for doing this and giving me the chance to participate and get my first bitcoin. Next goal is to be part of the 21 million club :p.
Thanks to all the contributors as well.
@MaxHillebrand I want to thank you in particular. Through your work on WCN I discovered bisq and then in their slack I read about the contribution game 25 days ago and since that time I am not sleeping well :p, so thank you a lot.
Most of the work that I did was simply code refactoring, and I acknowledge that it is not as worthy as others' contributions, but I will try to do better next time. I will be learning more about Bitcoin, Wasabi and C# to give back as much as I can.

@s-ben

This comment has been minimized.

Copy link

commented Jul 25, 2019

Hey all. So I’ve been tracking the contribution game using some OSS called SourceCred that scores contributions based on a modified version of Google’s PageRank algorithm. Thought I’d share the results here in case anyone found them interesting. An aim of this software is to be good enough to be used for direct crypto payments for contributions, which I think has a lot of promise as an alternative funding mechanism, as shown by the positive comments I'm seeing here.

image

If you want to tinker with the model, a hosted instance of the scores for WasabiWallet can be found here.

Note: this is just using the default settings; results can be tweaked quite a bit by customizing a few parameters.

P.S. Don’t wish to hijack convo! If you’d rather keep this thread on just the game results, happy to delete comment.

@raindogdance

This comment has been minimized.

Copy link
Contributor

commented Jul 26, 2019

Thank you to @nopara73 for setting up the game and keeping track, and to everyone involved. This has been fun! Honoured to have contributed, even though it's not much.

Also, my first bitcoin actually earned, wohoo! One thing more to cross of my checklist :)

@nopara73

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 26, 2019

@yahiheb Most of the work that I did was simply code refactoring, and I acknowledge that it is not as worthy as others' contributions, but I will try to do better next time.

You played by the rules and you won:)

@s-ben Please don't delete that post, it is exactly what we would've needed. In fact, during the game I felt the need for it so much that I started brainstorming on it and noted to myself as one of my "next project idea" to build a platform like yours. This could've come really handy and I never say this to non-well adopted projects, but I think we're going to use it next time. Assuming it works:)

@s-ben

This comment has been minimized.

Copy link

commented Jul 28, 2019

@nopara73 would be awesome to see SourceCred used next time! I'd like to call this platform mine, but it was started by people much smarter than I about a year and a half ago. Just found it recently and became obsessed, mainly because it already works as well as it does. They're looking for projects to partner with actually if you're interested. They could help you tweak the weights and customize it, show you how to use some recently added human moderation features. The design is in flux, but the README has a pretty good high-level description of what's going on, and if you have any questions, the maintainer is pretty responsive on their discord. I'm also looking to write a blog about SourceCred being used in a project. I think WasabiWallet would make a great case study if you were interested in providing some feedback about about it, how it compares to using GitHub metrics.

@nopara73

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 28, 2019

@s-ben Can you start an email conversation chain with me (adam.ficsor73@gmail.com)? Maybe also cc the maintainer you suggested to talk to (I assume @decentralion or @wchargin.)

@s-ben

This comment has been minimized.

Copy link

commented Jul 28, 2019

@nopara73, email sent! FYI @decentralion is in Berlin right now and pretty busy this week, so it might be a couple days before he can respond.

@Transisto

This comment has been minimized.

Copy link

commented Jul 29, 2019

Congratulation to all, Keep the good work!

@decentralion

This comment has been minimized.

Copy link

commented Jul 31, 2019

👋 SourceCred maintainer here. It's really cool to see the contribution game; running crypto airdrops to reward open-source was actually the inspiration for SourceCred, and it's great to see that it works in real life! I'd love to see SourceCred used for games like this and would be delighted to be of help any way I can. @nopara73, I replied on the email thread that @s-ben started. 😃

@MaxHillebrand

This comment has been minimized.

Copy link
Collaborator

commented Aug 5, 2019

FYI, there will be a monthly contribution game worth 1k USD for the contributors to the docs.wasabiwallet.io .

Maybe SourceCred is a valuable tool for this as well?

@benthecarman

This comment has been minimized.

Copy link
Collaborator

commented Aug 7, 2019

Crap, lost my winnings in a boating accident today!

@s-ben

This comment has been minimized.

Copy link

commented Aug 7, 2019

Post exploring the possibility of using SourceCred for the docs contribution game:
https://discourse.sourcecred.io/t/wasabi-wallet-documentation/139/5

@nopara73 nopara73 closed this Aug 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.