Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final tests before releasing 1.1.7. #2227

Closed
molnard opened this issue Sep 10, 2019 · 30 comments · Fixed by #2243

Comments

@molnard
Copy link
Collaborator

commented Sep 10, 2019

Final tests before release:

Download the pre-release and install it: https://github.com/zkSNACKs/WalletWasabi/releases/tag/1.1.7pre

  1. Test settings on/off button function and state save check with close-reopen Wasabi: #1823,

  2. Run the tests with dotnet run tests: WalletWasabi\WalletWasabi.Tests> dotnet test --filter "UnitTests"

  3. Test QR code: #1810, #1809

  4. Lurking wife mode on Transaction Viewer: #1827, #1835

  5. Change values on the Settings page. Change values back and forth and observe the changed message: #1850

  6. On WalletInfoView sensitive data color is red: #1841

  7. Test Send Tab functionality: #1872

  8. No fee slider on testnet: #1880

  9. Check Copy/Paste with buttons: #1882

  10. Check Hardware wallet detection: #1860

  11. Check privacy message on the Wallet info tab.

  12. Check CoinJoin inputs/outputs order: #1944

  13. Settings Dust input validation messages: #1789

  14. Check the lock screen, lock, set pin, clear pin, lock-exit-reopen: #1990, #1681

  15. Check openfiledialog: #1993

  16. Paste Bitcoin URL into SendTab address box: #1949

  17. Check TX id on Transaction Tab: #2008

  18. Use wallet for 5 minutes click everywhere us can and check the number of threads: #2033

  19. Check Manual Fee settings: #2006

  20. OSX Copy/Paste text with special characters: #2100

  21. Create PSBT and export it: #2186

  22. Check the new website, click everywhere, on mobile, in orion browser: https://wasabiwallet.io/

  23. Test the new passwordbox: #2187

  24. Check PSBT exceptions on Tx builder page: #2222

@molnard molnard added this to ToDo in v1.1.7 via automation Sep 10, 2019
@molnard molnard added the priority label Sep 10, 2019
@Rmartin1104

This comment has been minimized.

Copy link
Collaborator

commented Sep 10, 2019

PR Description WIN OSX LIN
1 Test settings on/off button function and state save check with close-reopen Wasabi
2 Run the tests with dotnet run tests
3 Test QR code
4 Lurking wife mode on Transaction Viewer
5 Change values on the Settings page. Change values back and forth and observe the changed message ---:
6 On WalletInfoView sensitive data color is red
7 Test Send Tab functionality ---:
8 No fee slider on testnet
9 Check Copy/Paste with buttons ---: ---:
10 Check Hardware wallet detection ---: ---:
11 Check privacy message NOT on the Wallet info tab.
12 Check CoinJoin inputs/outputs order
13 Settings Dust input validation messages ---:
14 Check the lock screen, lock, set pin, clear pin, lock-exit-reopen
15 Check openfiledialog ---:
16 Paste Bitcoin URL into SendTab address box ---:
17 Check TX id on Transaction Tab ---:
18 Use wallet for 5 minutes click everywhere us can and check the number of threads ---:
19 Check Manual Fee settings
20 OSX Copy/Paste text with special characters ---: ---: ---:
21 Create PSBT and export it ---: ---: ---:
22 Check the new website, click everywhere, on mobile, in orion browser
23 Test the new passwordbox ---: ---: ---:
24 Check PSBT exceptions on Tx builder page ---: ---: ---:
@Zolgarr

This comment has been minimized.

Copy link
Collaborator

commented Sep 10, 2019

On Mac at the settings tab, if I want to change the network from "Main" to something else, the options pop up in a way that is not visible:

image

@molnard molnard changed the title Before release tests 1.1.7. Final tests before releasing 1.1.7. Sep 10, 2019
@Zolgarr

This comment has been minimized.

Copy link
Collaborator

commented Sep 10, 2019

On Mac, when I ran the dotnet run tests, they were successful, but I received some error messages regarding the errorKeyManager:

image

@lontivero

This comment has been minimized.

Copy link
Collaborator

commented Sep 10, 2019

Autocopy On/Off switch doesn't work on Linux. Testing ec76f23 clicking the On/Off doesn't change the value stored in UiConfig.json. Fixed here #2229

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Sep 10, 2019

Downloading the release, I got Windows smartscreen complaining that I may shouldn't run this.

@molnard

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 10, 2019

Downloading the release, I got Windows SmartScreen complaining that I may shouldn't run this.

I tried to sign with the old signature too but it looks like it can have only one signature. It should be a renewal signature but we fixed the typo in zkSNACKs maybe that is why we got smartscreen.

@molnard

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 10, 2019

Autocopy On/Off switch doesn't work on Linux. Testing ec76f23 clicking the On/Off doesn't change the value stored in UiConfig.json. Fixed here #2229

Good catch, it is not in the pre-release but it will be in the release.

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Sep 10, 2019

Windows smartscreen complaining

We will have to live with that until enough people downloads the software to get enough reputation for our new signing key.

@lontivero

This comment has been minimized.

Copy link
Collaborator

commented Sep 10, 2019

image
This doesn't look good enough to me.

@lontivero

This comment has been minimized.

Copy link
Collaborator

commented Sep 10, 2019

If we set an invalid TorEndpoint like "127.0.0.19050" we are not alerted and then when Wasabi starts it cannot connect to Tor.

@lontivero

This comment has been minimized.

Copy link
Collaborator

commented Sep 10, 2019

image
If I set 0,00010000 as dust threshold (this is 0.0001 in local culture) the value is settled as 10000.00. Are we okay with that?

@lontivero

This comment has been minimized.

Copy link
Collaborator

commented Sep 10, 2019

There is a problem with the manual fee:

image

Now add a bigger fee manually and see the "No Coins Selected" message appears when there are coins selected, it is just that you are paying all in fees and 0btc output.
image

@lontivero

This comment has been minimized.

Copy link
Collaborator

commented Sep 10, 2019

I see that in the Wallet Info tab the Lurking Wife Mode does not mask the most critical info. I am sorry for being asking this so late but is that a design decision?
image

@yahiheb

This comment has been minimized.

Copy link
Collaborator

commented Sep 10, 2019

I see that in the Wallet Info tab the Lurking Wife Mode does not mask the most critical info.

I agree that info should be hidden when the Lurking Wife Mode is enabled.

@yahiheb

This comment has been minimized.

Copy link
Collaborator

commented Sep 10, 2019

Receive tab: Should we hide the QRCode of the address and the public key?

receive tab

@yahiheb

This comment has been minimized.

Copy link
Collaborator

commented Sep 10, 2019

Send tab: Should we hide the info when we expand the coin's details?

Send tab

@bharmat

This comment has been minimized.

Copy link

commented Sep 10, 2019

Manual fee selection:

  • Cursor is not working in the box (edit: you have to keep pressing the arrow buttons to move the cursor, unlike in other fields)
  • Can't erase the default number only for a fraction of a second, then it automatically changes back to the default. If I'm quick enough with backspace and the desired amount then its ok, but its really a fraction of a second.
  • "or set Fee" could be horizontally centered
    MacOS
@yahiheb

This comment has been minimized.

Copy link
Collaborator

commented Sep 10, 2019

When sending a transaction the selected amount is hidden but when you type the amount to be sent or you click max the amount is not hidden.

Send coin

@lontivero

This comment has been minimized.

Copy link
Collaborator

commented Sep 10, 2019

Manual fee selection:

* Cursor is not working in the box

* Can't erase the default number only for a fraction of a second, then it automatically changes back to the default. If I'm quick enough with backspace and the desired amount then its ok, but its really a fraction of a second.

* "or set Fee" could be horizontally centered
  MacOS

I saw the same in Linux. The textbox is empty after sending and in some corner cases when you use custom fee like 1.009999999 the calculated value displayed in the Amount textbox is one satoshi off (it says 0.09876543 and you receive 0.09876542). The problem is not the satoshi but the allowed precision in the custom fee textbox, it is too much.

@bharmat

This comment has been minimized.

Copy link

commented Sep 10, 2019

Lock Screen:

  • PIN is set, screen locked, then unlocked.
  • Now locking it again and the field of PIN is filled (with the four dots) and the CLEAR and BACK buttons are not working.
  • After manually erasing the dots with backspace it is possible to unlock.
    MacOS
@lontivero

This comment has been minimized.

Copy link
Collaborator

commented Sep 10, 2019

Max number of thread while mixing was 37 with 30 threads average.

@benthecarman

This comment has been minimized.

Copy link
Collaborator

commented Sep 10, 2019

On the release notes it says

RBF support: #2088

This should probably just be under "Minor bug fixes and improvements", people might think it is adding support to flag txs as rbf

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Sep 11, 2019

Summary of found issues:

  • OSX Settings Network - wontfix for this release, waiting for Avalonia
  • Test error logs - error logs are expected, so it's good.
  • Autocopy On/Off - fixed
  • SmartScreen - cantfix, have to wait for enough ppl to use our sig and gain MS reputation
  • Fee too low + manual fee entry looks ugly - testnet only edge case, no need to fix for release.
  • If we set an invalid TorEndpoint like "127.0.0.19050" we are not alerted and then when Wasabi starts it cannot connect to Tor - works as intended
  • If I set 0,00010000 as dust threshold (this is 0.0001 in local culture) the value is settled as 10000.00. Are we okay with that? - ???
  • No Coins Selected Manual Fee issue - wontfix, retarded edge case
  • Lurking Wife Mode - works as intended
  • Manual Fee - Cursor is not working in the box
  • Manual Fee - Can't erase the default number only for a fraction of a second - works as intended
  • Lock Screen - fixing? https://github.com/zkSNACKs/WalletWasabi/pulls
  • RBF support wrong release note
@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Sep 11, 2019

@lontivero "No Coins Selected" appears when fee becomes larger than the selected coins. If you select another coin, it'll be corrected. It's a bit retarded edge case and the recent work on the SendTab we made the tab super complicated, so I think it should be only fixed with refactoring.

@molnard

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 11, 2019

If we set an invalid TorEndpoint like "127.0.0.19050" we are not alerted and then when Wasabi starts it cannot connect to Tor.

This is fine IMO, the user will get the Tor is not running which obviously means that there is a problem with the Tor or with the settings so he will check that automatically. Also, there are some lines in the Log file about this,

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Sep 11, 2019

If we set an invalid TorEndpoint like "127.0.0.19050" we are not alerted and then when Wasabi starts it cannot connect to Tor.

The Tor is not running status is the alert itself. Works as intended.

@molnard

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 11, 2019

image
If I set 0,00010000 as dust threshold (this is 0.0001 in local culture) the value is settled as 10000.00. Are we okay with that?

Fixed here: #2238

@molnard

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 11, 2019

Manual fee selection:

  • Cursor is not working in the box (edit: you have to keep pressing the arrow buttons to move the cursor, unlike in other fields)

Fixed here: #2239

@danwalmsley

This comment has been minimized.

Copy link
Collaborator

commented Sep 11, 2019

File -> Recover Wallet doesnt work after clicking open wallets folder.

ok, thats apples trackpad being wierd! forgive me! not a bug!

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Sep 11, 2019

Number of threads: after 5-10min, windows, debug mode, not mixing: 32

v1.1.7 automation moved this from ToDo to Done Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v1.1.7
  
Done
9 participants
You can’t perform that action at this time.