New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arch Linux issues #758

Closed
nopara73 opened this Issue Oct 25, 2018 · 15 comments

Comments

Projects
None yet
4 participants
@nopara73
Collaborator

nopara73 commented Oct 25, 2018

image

@nopara73 nopara73 added the debug label Oct 25, 2018

@nopara73

This comment has been minimized.

Collaborator

nopara73 commented Oct 25, 2018

When trying to run the self-contained binary:

image

@danwalmsley Any idea what can it be?

@danwalmsley

This comment has been minimized.

Contributor

danwalmsley commented Oct 25, 2018

This version of Arch does not have any suitable font found. @lontivero is there any decent guaranteed fonts available across Linux distributions?, currently avalonia has no way to detect the system font.

@Gillibald did you make progress with finding a fix for this?

@Gillibald

This comment has been minimized.

Gillibald commented Oct 25, 2018

Will make a fix available shorty. Just had not much time but will sneak this in.

@lontivero

This comment has been minimized.

Contributor

lontivero commented Oct 25, 2018

@lontivero is there any decent guaranteed fonts available across Linux distributions?

I don't know and I don't think so. I've read that Verdana is one of the most commonly available fonts, however I think that having a cascade of fall back fonts could help in this case but I really don't know if that is already implemented.

@Gillibald

This comment has been minimized.

Gillibald commented Oct 25, 2018

Font fallbacks are implemented. The issue here is that the system's default isn't automatically used when no font can be found. Need to test my fix before submitting a PR tomorrow. After the fix it should use the system's default if our defined default isn't present on the system.

@danwalmsley

This comment has been minimized.

Contributor

danwalmsley commented Oct 25, 2018

The problem is iv specified a cascade of fonts that look great on windows and mac, and some that work on Linux, however in this distribution it hasn't found any font.

@nopara73

This comment has been minimized.

Collaborator

nopara73 commented Oct 27, 2018

For the shake of tracking. I think either AvaloniaUI/Avalonia#2032 or AvaloniaUI/Avalonia#2026 will fix the first problem with Arch.

@nopara73

This comment has been minimized.

Collaborator

nopara73 commented Oct 28, 2018

As a bit of an update. All tests pass properly on Arch, so Tor is properly picked up. There may be some threading/synchronization context when the app is launched from Gui, regarding the reported Tor issue, but I cannot try it until the font issues are fixed.

@danwalmsley

This comment has been minimized.

Contributor

danwalmsley commented Oct 28, 2018

@nopara73 if you override the ui font you can try it, just put FontFamily="AnFontName" at the top of MainWindow, or search for where UiFont is declared and replace there.

(just to try if avalonia is blocking you)

@nopara73

This comment has been minimized.

Collaborator

nopara73 commented Oct 29, 2018

@danwalmsley It doesn't work. I've been playing with it for hours now, nothing works, nor FontFamily=new FontFamily("system-ui"); I don't know what am I doing wrong.

@Gillibald

This comment has been minimized.

Gillibald commented Oct 29, 2018

Is it crashing on new FontFamily("system-ui")?

@nopara73

This comment has been minimized.

Collaborator

nopara73 commented Oct 29, 2018

@Gillibald Yes, same error message, so my guess was I'm placing it to the wrong place or something overrides it.

Wrong Place

For the record I was placing it to the beginning of the MainWindow's constructor:

public MainWindow()
{
InitializeComponent();

Something Else Affects It

And I noticed there 3-4 FontFamily xml properties in various places, like FontFamily="{DynamicResource UiFont}" FontSize="14" Foreground="{DynamicResource ThemeForegroundBrush}" which I am not sure what they are doing.

@Gillibald

This comment has been minimized.

Gillibald commented Oct 29, 2018

You should try changing FontFamily="{DynamicResource UiFont}" to FontFamily="system-ui"

Still, this shouldn't crash. Are you guys using the latest master?

@nopara73

This comment has been minimized.

Collaborator

nopara73 commented Oct 29, 2018

@Gillibald I am a bit confused by how we are using Avalonia, because we are using submodules (and submodule of submodule that also uses Avalonia,) nuget packages and also somehow we use the latest build of Avalonia through Directory.Build.targets file, which I don't fully understand. In fact, I asked @danwalmsley yesterday to explain this in the next PR he's going to make today. Since I have about 10 different OSes to test, I'll wait until his PR and see if things work with that and only mess around with it if it doesn't.

@nopara73

This comment has been minimized.

Collaborator

nopara73 commented Oct 30, 2018

Fixed: #766

@nopara73 nopara73 closed this Oct 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment