Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate somehow if a round fails. #841

Closed
bharmat opened this issue Nov 14, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@bharmat
Copy link

commented Nov 14, 2018

If a round fails due to someone's poor net connection, Tor, etc it seems like from the client side, that the round was successful, although the CoinJoin did not happen.
Would it be possible to show somehow whether the round was successful or not?
Maybe indicating it with the circles ("registration", "confirming connection", "registering outputs", "signing") where the process fails. I guess it is usually the signing, so at the end of the process the last circle could turn red, if the signing fails.
This would provide information for the user and probably easier to solve than issue #839 which would be a solution to make all rounds successful.
On the other hand the Round ID does not provide too much information, maybe it could count the successful rounds.

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Nov 14, 2018

Concept ACK. We've just implemented showing successful rounds. The red circle will be a good, uncontroversial addition to show the opposite.

image

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Nov 15, 2018

Done (red circles): #848

@nopara73 nopara73 closed this Nov 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.