Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ConcurrentHashSet NuGet by writing our own #900

Closed
nopara73 opened this issue Nov 28, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@nopara73
Copy link
Collaborator

commented Nov 28, 2018

In light of the recent npm hack (dominictarr/event-stream#116) we should strive for removing some NuGet packages.
I think ConcurrentHashSet NuGet can be easily replaced by our own implementation. (Encapsulating a ConcurrentDictionary by dismissing the Value field.)

@lontivero

This comment has been minimized.

Copy link
Contributor

commented Nov 28, 2018

That's a one file library. We can include it in Wasabi as a first step and the work in replacing it. Let me do it.

@nopara73 nopara73 closed this in a8ab7f8 Nov 28, 2018

@nopara73

This comment has been minimized.

Copy link
Collaborator Author

commented Nov 28, 2018

@lontivero Sorry, already done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.