Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HW wallet offline transaction UI #1351

Merged
merged 80 commits into from May 1, 2019

Conversation

Projects
None yet
3 participants
@molnard
Copy link
Contributor

commented Apr 19, 2019

  • Add Transaction Broadcaster to ToolCommands - don't need.
  • Add Icon as a resource in WalletExplorerView.xaml
  • Investigate MultiLine TextBox bugs
  • Scroll bug on MultiLine Textbox
  • SendTab: test vector still used, use original tr instead.
  • Exit button in main menu - not working. Issue opened.
  • Tx Broadcast can be opened twice - don't need.

molnard added some commits Apr 19, 2019

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Apr 20, 2019

What do you think about modifying the plan a bit like this?

If normal wallet, then tabs are:

  • Send
  • Receive
  • CoinJoin
  • History
  • Advanced: Info
  • Advanced: Build Transaction
  • Advanced: Broadcast Transaction

If IsWatchOnly then tabs are:

  • Receive
  • CoinJoin
  • History
  • Advanced: Info
  • Advanced: Build Transaction
  • Advanced: Broadcast Transaction

If IsHardwareWallet then tabs are

  • Send
  • Receive
  • CoinJoin
  • History
  • Advanced: Info
  • Advanced: Build Transaction
  • Advanced: Broadcast Transaction

Plus: Tools/Transaction Broadcaster

@molnard

This comment has been minimized.

Copy link
Contributor Author

commented Apr 20, 2019

It fits into the plan I can do it. So the PSBT viewer should be named as Build Transaction?

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Apr 20, 2019

Yes.

molnard added some commits Apr 20, 2019

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Apr 21, 2019

In fact, people are complaining that Wasabi is hard to use, so I think we should do the Visual Studio Design (you can steal what AvalonStudio does) and add expander:

> Advanced
Info
Build Transaction
Broadcast Transaction

So the Advanced tabs wouldn't be in the face of the normal user.

@molnard

This comment has been minimized.

Copy link
Contributor Author

commented Apr 21, 2019

If I have an IsWatchOnly wallet I cannot generate PSBT because Send Tab is missing. Make it visible?

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Apr 21, 2019

Wanna try VS2019 live coding tool?

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Apr 21, 2019

In IsWatchOnly the Build Transaction tab should appear only. I guess that's just a renaming of Send Tab and a few visibility things.

nopara73 and others added some commits Apr 21, 2019

Merge branch 'master' into hwiui
# Conflicts:
#	WalletWasabi.Gui/Controls/WalletExplorer/SendTabViewModel.cs
Merge branch 'hwiui' of github.com:molnard/WalletWasabi into hwiui
# Conflicts:
#	WalletWasabi.Gui/Controls/WalletExplorer/SendTabViewModel.cs

nopara73 added some commits Apr 30, 2019

nopara73 added some commits Apr 30, 2019

@nopara73 nopara73 marked this pull request as ready for review Apr 30, 2019

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Apr 30, 2019

@lontivero This PR is ready. Can you review it?

nopara73 added some commits May 1, 2019

@nopara73 nopara73 referenced this pull request May 1, 2019

Open

Normalize Colors #1394

nopara73 and others added some commits May 1, 2019

Merge branch 'hwiui' of https://github.com/molnard/WalletWasabi into …
…pr/1351-hw-wallet-offline-transaction-ui
Merge branch 'hwiui' of https://github.com/molnard/WalletWasabi into …
…pr/1351-hw-wallet-offline-transaction-ui

@nopara73 nopara73 merged commit 815fc33 into zkSNACKs:master May 1, 2019

1 of 4 checks passed

Wasabi.Linux in progress
Details
Wasabi.Osx in progress
Details
Wasabi.Windows in progress
Details
CodeFactor No issues found.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.