Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create FAQ.md #1416

Merged
merged 13 commits into from May 19, 2019

Conversation

Projects
5 participants
@6102bitcoin
Copy link
Contributor

commented May 6, 2019

Copy of FAQ from my FAQ Repo (https://github.com/6102bitcoin/FAQ/)
Thanks to Max Hillebrand for the suggested improvements & fixes.

Create FAQ.md
Copy of FAQ from my FAQ Repo (https://github.com/6102bitcoin/FAQ/)
Thanks to Max Hillebrand for the suggested improvements & fixes.

I am not aware of any wallets for iOS which support coin control. If you are aware of any other Wallets with coin control please make a pull request.

Be careful. If you send all your coins from an old wallet to a new wallet (from the table above) in one transaction then you will merge all your coins which is bad for privacy. Instead, **import your seed into one of the wallets in the table.**

This comment has been minimized.

Copy link
@nopara73

nopara73 May 8, 2019

Collaborator

This is, while good, an impractical advice unfortunately :(

This comment has been minimized.

Copy link
@6102bitcoin

6102bitcoin May 8, 2019

Author Contributor

How so?

This comment has been minimized.

Copy link
@nopara73

nopara73 May 11, 2019

Collaborator
  1. 99% of users would fail to figure out what to do.
  2. Gap limit issues.
  3. Core is not compatible with other wallets.
  4. Wasabi is only looking at bech32 keys, this can result in a lot of confusion.
  5. Keypath issues.
  6. xpub format issues: xpub hex, xpub, ypub, zpub, etc are not standards and used differently wallet by wallet.
  7. Import Wasabi seed to a mobile wallet and you doxxed yourself and all your past mixes to the company.

And these are just from the top of my head.

nopara73 and others added some commits May 8, 2019

Apply suggestions from code review
Added suggestions that do not require further discussion

Co-Authored-By: 6102bitcoin <42300012+6102bitcoin@users.noreply.github.com>
Show resolved Hide resolved WalletWasabi.Documentation/FAQ.md Outdated
Show resolved Hide resolved WalletWasabi.Documentation/FAQ.md Outdated
Show resolved Hide resolved WalletWasabi.Documentation/FAQ.md
Show resolved Hide resolved WalletWasabi.Documentation/FAQ.md
Show resolved Hide resolved WalletWasabi.Documentation/FAQ.md Outdated
Show resolved Hide resolved WalletWasabi.Documentation/FAQ.md Outdated
Apply suggestions from code review
Added suggestions

Co-Authored-By: Max Hillebrand <30683012+MaxHillebrand@users.noreply.github.com>
Small Fixes
Thanks @dergigi for the suggested changes (6102bitcoin/FAQ#4)
Update WalletWasabi.Documentation/FAQ.md
Co-Authored-By: nopara73 <adam.ficsor73@gmail.com>
@cryptal

This comment has been minimized.

Copy link

commented May 14, 2019

This is great! Would love to see the FAQ included in Wasabi somehow, e.g. in/near the Advanced Information option, either as a link, or embedded.

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented May 15, 2019

@cryptal good idea. How about Help/FAQ would open a browser and navigate to the FAQ. Since we're here we could add a link to the Dojo, too. (And a link to the FAQ from the website.)

@6102bitcoin

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2019

Sounds like a great idea

@nopara73 nopara73 referenced this pull request May 18, 2019

Merged

Patch FAQ #2

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented May 18, 2019

@6102bitcoin I've created a PR to you (6102bitcoin#2) with the mentioned changes.

After that's merge, I merge this.

@nopara73 nopara73 added this to In Progress in v1.1.5 via automation May 19, 2019

@nopara73 nopara73 merged commit 73877a5 into zkSNACKs:master May 19, 2019

3 of 4 checks passed

Wasabi.Linux #20190518.2 failed
Details
CodeFactor No issues found.
Details
Wasabi.Osx #20190518.2 succeeded
Details
Wasabi.Windows #20190518.2 succeeded
Details

v1.1.5 automation moved this from In Progress to Done May 19, 2019

@6102bitcoin

This comment has been minimized.

Copy link
Contributor Author

commented May 19, 2019

Aww Yeah!
Cheers Adam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.